Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initial loading limit of user management on large screens #12820

Merged
merged 1 commit into from
Dec 18, 2014

Conversation

MorrisJobke
Copy link
Contributor

ref #12620

Steps to reproduce:

  • have a large screen (vertical height) where more than 10 user rows fits in
  • open user management
  • before this fix: just 10 users are loaded - no lazy loading because there is no scrolling -> no invocation of lazy loading
  • after this fix: the whole screen list users and there are even more - on scrolling the lazy load of additional users hits in
  • requirement: many users (if you just have 10 users it won't show more ;))

cc @PVince81 @LukasReschke @blizzz

@MorrisJobke MorrisJobke added this to the 8.0-current milestone Dec 12, 2014
@LukasReschke
Copy link
Member

Will test on monday.

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 2 updated code elements

@MorrisJobke
Copy link
Contributor Author

failing tests are unrelated

@MorrisJobke
Copy link
Contributor Author

@LukasReschke Monday is over ;)

@ghost
Copy link

ghost commented Dec 16, 2014

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/4572/
🚀 Test PASSed. 🚀

@LukasReschke
Copy link
Member

@MorrisJobke Obviously I meant next monday cough cough ;-)

👍

@RobinMcCorkell
Copy link
Member

Ah, the Tumblr problem. Code looks good 👍

RobinMcCorkell pushed a commit that referenced this pull request Dec 18, 2014
fix initial loading limit of user management on large screens
@RobinMcCorkell RobinMcCorkell merged commit a341f96 into master Dec 18, 2014
@RobinMcCorkell RobinMcCorkell deleted the user-management-on-large-screens branch December 18, 2014 00:47
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants