Delay getRootFolder from RemoveRootShares repair step #25158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @rullzer, @DeepDiver1975 and @nickvergessen to be potential reviewers |
|
Wtf seriously? But please use the lazyrootfolder then... (I know I should have used that anyways)... |
This prevents the command registration to setup the FS too early when FS-related apps might need upgrading.
PVince81
force-pushed
the
removerootshares-delaygetrootfolder
branch
from
b3cabf8
to
73e284e
Compare
|
@rullzer adjusted to use getLazyRootFolder and retested, works fine |
|
👍! Best of both worlds DI and Lazy :) |
|
Looks good 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the command registration to setup the FS too early when
FS-related apps might need upgrading.
Fixes #25156
Please review @owncloud/sharing @owncloud/filesystem @DeepDiver1975 @butonic