-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to filter by tags with REPORT method #26099
Conversation
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @nickvergessen and @DeepDiver1975 to be potential reviewers |
I just saw that we can actually have different report types using the report name. The report here was called "filter-files". The question maybe is whether we want to separate all these into separate reports:
|
The advantage of a single "filter-files" report is that you can combine filters and intersect results, but it also increases complexity because of this. |
@PVince81
If yes, consider my comment for 👍 |
@VicDeo yes, this happens when requesting a property that doesn't exist on all nodes. |
@DeepDiver1975 @butonic do we agree on the API-side of this ? Basically use multiple filters within the same report "filter-files". |
Enhanced the REPORT method on the Webdav endpoint and added a "oc:favorite" filter rule. When set, it will return a flat list of results filtered with only favorite files. The web UI was also adjusted to use this REPORT method instead of the private API endpoint.
85a0b36
to
1a5b4e1
Compare
basically the report tesult is a list of files. What we want to change are the filter criteria, eg. by favorite, tag, mtime range, file name, file content ... so yes, keep a single filter-files report. |
Thanks, merging. Pagination as it was mentionned is a topic for another time, see #13915. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Enhanced the REPORT method on the Webdav endpoint and added a
"oc:favorite" filter rule. When set, it will return a flat list of
results filtered with only favorite files.
The web UI was also adjusted to use this REPORT method instead of the
private API endpoint.
Related Issue
Fixes #23263
Motivation and Context
This makes it possible for other clients like desktop and mobile to retrieve a flat filtered list of favorite files. The previous API was private and was not supposed to be used, but the REPORT method and the webdav endpoint are public. @davivel @nasli @dragotin @guruz
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Please review @DeepDiver1975 @butonic @VicDeo @guruz @davivel @SergioBertolinSG @nasli