[10.0] Add Redis Cluster support #26407

DeepDiver1975 · 2016-10-19T10:54:36Z

Description

Adding support for redis clustering
Restart of #23204

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

mention-bot · 2016-10-19T10:54:39Z

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @butonic and @nickvergessen to be potential reviewers.

butonic · 2016-10-19T11:19:25Z

lib/private/RedisFactory.php

+				throw new \Exception('Redis Cluster support is not available');
+			}
+			// cluster config
+			$timeout = isset($config['timeout']) ? $config['timeout'] : null;


we are not using the ternary operator

ternary has no isset support, so it can not be used in such cases

butonic · 2016-11-11T10:53:38Z

Some notes for testing this:

Requires phpredis v3.0.0 which introduces the needed RedisCluster class: https://github.com/phpredis/phpredis/blob/feature/redis_cluster/cluster.markdown#redis-cluster
debian sid is at 2.2.7: https://packages.debian.org/source/sid/php-redis
v3.0.0 via pecl requires PHP 7: https://pecl.php.net/package/redis
v2.2.8 via pecl also contains the RedisCluster class and is compatible with php 5.6

with v2.2.8 and a small fix, see upstream doc example the PR works as expected! 👍

butonic · 2016-11-11T11:42:53Z

@Ethendrel care to review? Then we can finally merge redis cluster support!

PVince81 · 2017-01-31T10:35:20Z

@owncloud/qa quick manual test and create plan to have automated tests for this ?

DeepDiver1975 · 2017-02-07T10:25:55Z

create plan to have automated tests for this

our plans for the dockerized integration tests could help a lot here
@tboerger - can we haz a redis cluster docker-composer setup plez?

tboerger · 2017-02-24T11:41:37Z

our plans for the dockerized integration tests could help a lot here
@tboerger - can we haz a redis cluster docker-composer setup plez?

Which kind of cluster? :)

DeepDiver1975 · 2017-02-24T12:34:02Z

Which kind of cluster? :)

redis 😉

tboerger · 2017-02-24T14:27:22Z

redis 😉

Never used a redis cluster, so you want some sentinel based cluster?

DeepDiver1975 · 2017-02-24T15:15:25Z

@butonic please let @tboerger know what kind do of redis cluster we need

butonic · 2017-02-26T18:54:24Z

Nope, just as in the redis cluster tutorial: https://redis.io/topics/cluster-tutorial 3 master, 3 slaves. The failover and promotion should be handled by this setup and the redis client, AFAICT. The client side does come with a fail over strategy config option: https://github.com/phpredis/phpredis/blob/feature/redis_cluster/cluster.markdown#automatic-slave-failover--distribution

pmaier1 · 2017-03-21T14:39:21Z

we can test this in 10.0.0beta with a customer, if we merge it for the beta release.
@PVince81

pmaier1 · 2017-03-21T14:39:53Z

Please cover with dokcer reds cluster infrastructure for testing @tboerger

DeepDiver1975 · 2017-03-21T14:53:02Z

we can test this in 10.0.0beta with GWDG, if we merge it for the beta release.

who can coordinate a test setup? @pmaier1

@PVince81 let's merge this one

PVince81 · 2017-03-21T15:00:19Z

Ok then 👍

@DeepDiver1975 please add to the feature list in the wiki

pmaier1 · 2017-03-21T17:14:07Z

who can coordinate a test setup? @pmaier1

I will coordinate this along with the beta.

PVince81 · 2017-04-07T15:13:54Z

QA ticket owncloud/QA#411

lock · 2019-08-03T14:02:30Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

DeepDiver1975 added the 3 - To Review label Oct 19, 2016

DeepDiver1975 added this to the 9.2 milestone Oct 19, 2016

butonic reviewed Oct 19, 2016

View reviewed changes

butonic force-pushed the redis-cluster-tom branch from a4c677c to 59c8de9 Compare November 11, 2016 10:54

butonic self-assigned this Nov 28, 2016

DeepDiver1975 changed the title ~~[9.2] Add Redis Cluster support~~ [10.0] Add Redis Cluster support Jan 31, 2017

RobinMcCorkell and others added 3 commits January 31, 2017 11:02

Add Redis Cluster support

8406c64

fix constant

ffc6406

no ternary

a863dec

DeepDiver1975 force-pushed the redis-cluster-tom branch from 33e174d to a863dec Compare January 31, 2017 10:02

DeepDiver1975 merged commit ec9a9c9 into master Mar 21, 2017

DeepDiver1975 deleted the redis-cluster-tom branch March 21, 2017 15:02

MorrisJobke mentioned this pull request Mar 26, 2017

Redis cluster support nextcloud/server#4061

Merged

1 task

PVince81 mentioned this pull request Apr 7, 2017

Test redis cluster owncloud/QA#411

Open

PVince81 mentioned this pull request Apr 7, 2017

Clustered ownCloud with clustered Redis in HA environment #21448

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0] Add Redis Cluster support #26407

[10.0] Add Redis Cluster support #26407

DeepDiver1975 commented Oct 19, 2016 •

edited

Loading

mention-bot commented Oct 19, 2016

butonic Oct 19, 2016

nickvergessen Oct 19, 2016

butonic commented Nov 11, 2016 •

edited

Loading

butonic commented Nov 11, 2016

PVince81 commented Jan 31, 2017

DeepDiver1975 commented Feb 7, 2017

tboerger commented Feb 24, 2017

DeepDiver1975 commented Feb 24, 2017

tboerger commented Feb 24, 2017

DeepDiver1975 commented Feb 24, 2017 •

edited

Loading

butonic commented Feb 26, 2017 via email •

edited

Loading

pmaier1 commented Mar 21, 2017 •

edited

Loading

pmaier1 commented Mar 21, 2017

DeepDiver1975 commented Mar 21, 2017

PVince81 commented Mar 21, 2017

pmaier1 commented Mar 21, 2017

PVince81 commented Apr 7, 2017

lock bot commented Aug 3, 2019

[10.0] Add Redis Cluster support #26407

[10.0] Add Redis Cluster support #26407

Conversation

DeepDiver1975 commented Oct 19, 2016 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

mention-bot commented Oct 19, 2016

butonic Oct 19, 2016

Choose a reason for hiding this comment

nickvergessen Oct 19, 2016

Choose a reason for hiding this comment

butonic commented Nov 11, 2016 • edited Loading

butonic commented Nov 11, 2016

PVince81 commented Jan 31, 2017

DeepDiver1975 commented Feb 7, 2017

tboerger commented Feb 24, 2017

DeepDiver1975 commented Feb 24, 2017

tboerger commented Feb 24, 2017

DeepDiver1975 commented Feb 24, 2017 • edited Loading

butonic commented Feb 26, 2017 via email • edited Loading

pmaier1 commented Mar 21, 2017 • edited Loading

pmaier1 commented Mar 21, 2017

DeepDiver1975 commented Mar 21, 2017

PVince81 commented Mar 21, 2017

pmaier1 commented Mar 21, 2017

PVince81 commented Apr 7, 2017

lock bot commented Aug 3, 2019

DeepDiver1975 commented Oct 19, 2016 •

edited

Loading

butonic commented Nov 11, 2016 •

edited

Loading

DeepDiver1975 commented Feb 24, 2017 •

edited

Loading

butonic commented Feb 26, 2017 via email •

edited

Loading

pmaier1 commented Mar 21, 2017 •

edited

Loading