-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stable9.1] Backporting logging changes of PR #27144 #27239
Conversation
@noveens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @butonic and @DeepDiver1975 to be potential reviewers. |
@PVince81 , |
lib/private/BackgroundJob/Job.php
Outdated
$jobStartTime = time(); | ||
|
||
\OCP\Util::writeLog('cron', 'Started background job of class : ' . get_class($this) . ' with arguments : ' . print_r($this->argument, true), \OCP\Util::DEBUG | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the );
up or split the line better.
lib/private/BackgroundJob/Job.php
Outdated
$timeTaken = $jobEndTime - $jobStartTime; | ||
|
||
\OCP\Util::writeLog('cron', "Finished background job, the job took : $timeTaken seconds, " . "this job is an instance of class : " . get_class($this) . ' with arguments : ' . print_r($this->argument, true), \OCP\Util::DEBUG | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the ); up or split the line better.
yes |
@jvillafanez @PVince81 , |
👍 |
@PVince81 , |
Looks like we overlooked a missing whitespace...
Note the @noveens could you create another PR to fix this? |
@jvillafanez , |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
backporting logging changes of PR #27144