-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libs and pin version to 5.6 #29822
Conversation
Hmm, we should also update the libs in "apps/files_external"... but for that I'd rather we first move out the backends and update the libs then: #27542 |
|
|
470c7e9
to
2789995
Compare
I discovered the Sabre VObject version bump last week when rebasing the Guzzle version PR: It will be good to have that merged into master so I can remove the commit from Guzzle changes. |
Updated JS libs to latest minor versions. To retest:
Note: we should consider major release update for 10.1. Note that jquery update will break a lot of things so need to plan some time... |
Codecov Report
@@ Coverage Diff @@
## master #29822 +/- ##
============================================
+ Coverage 60.51% 60.59% +0.08%
- Complexity 18374 18487 +113
============================================
Files 1090 1091 +1
Lines 60933 61232 +299
============================================
+ Hits 36874 37105 +231
- Misses 24059 24127 +68
Continue to review full report at Codecov.
|
We should also look at have the new Sabre changes released so we can update to it for #28341 |
|
No output for |
Regarding timezone, I didn't find what code uses it, maybe it's obsolete. Anyway, I checked the hidden input fields and their value was set correctly, so the library update worked. |
👍 for @DeepDiver1975's test fixes. Review for the update in general ? I think we should backport this afterwards. |
@DeepDiver1975 can you take care of the backport and version updates in general ? seems the libs updated again... |
@PVince81 @DeepDiver1975 I see a backport request label here, but it did not get backported. |
That would be nice, yes |
PR #30430 has what would be the backported code for |
All needed backports are done. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Update dependencies to latest version compatible with PHP 5.6.32.
Pinned version to PHP 5.6.32 because if you update the libs with composer of PHP 7 it might pick the wrong versions... So better be safe.
This PR is to be backported to stable10.
At some point we can redo the same and pin to PHP 7.1 for 10.1 on master.
Things to retest: