Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Use PHP 7.4 for behat acceptance test dependencies #38066

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 2, 2020

Description

See the issue for details of the problem. Summary: with composer 2.0, behat gets errors when trying to load its dependencies with PHP 7.2 and 7.3. It works OK with PHP 7.4

  1. make separate make-file targets for each vendor-bin tool
  2. just install the needed vendor-bin tool(s) for each pipeline - this reduces the amount of crud that keeps getting installed
  3. lock behat to PHP 7.4 - that is fine because we are happy to run the behat testrunner only on PHP 7.4. There is no need to "test the test runner" on older PHP versions

This works-around the problem. There is likely some dependency of behat that needs to have something sorted out for composer 2.0 and PHP 7.2/7.3. But actually we don't really care about that!

Related Issue

Fixes #38067

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Nov 2, 2020
@phil-davis
Copy link
Contributor Author

core runs some pipelines with S3 storage. That fetches files_primary_s3. And that also has a similar dependency issue.
So this needs owncloud/files_primary_s3#395 merged first.

@phil-davis
Copy link
Contributor Author

Restarted drone CI. Let's see the result in an hour...

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI dependencies are broken
2 participants