Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Adjust then steps for the unsuccessful sharing scenarios #38068

Merged
merged 2 commits into from
Nov 3, 2020
Merged

[Tests-Only] Adjust then steps for the unsuccessful sharing scenarios #38068

merged 2 commits into from
Nov 3, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Nov 2, 2020 •
edited
Loading

Description

The Then step checks for the unhappy-path sharing scenarios are improved such that no shares are found in the pending state even after the status code is checked.

Related Issue

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor

See issue #38067 and PR #38066

@jasson99 jasson99 marked this pull request as ready for review November 2, 2020 10:23
@jasson99 jasson99 self-assigned this Nov 2, 2020
@jasson99 jasson99 changed the title [Tests-Only] [Tests-Only] Adjust then steps for the unsuccessful sharing scenarios Nov 2, 2020
@phil-davis
Copy link
Contributor

Rebased again to get good CI.

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 4e38bbe into master Nov 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the reviewUnhappySharing branch November 3, 2020 04:27
This was referenced Nov 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@jasson99 jasson99

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasson99 @phil-davis