[tests-only] Tidy up user cleanup when running on OCIS or reva

[phil-davis]

Description

PR owncloud/ocis#1962 has been merged in OCIS. That has fixed the user delete so that all files of a user are deleted when the user is deleted. But it doesn't seem to have fixed it for owncloud storage.

We can remove the special code that does a default attempt to delete the user's files, unless the storage driver is owncloud

Note: there is also cleanup code that does:

	$this->deleteAllSharesForUser($user["actualUsername"]);

That may not be needed any more. I will make a separate PR to remove that and test if it is really needed or not.

How Has This Been Tested?

CI
owncloud/ocis#1982 demonstrates that this works OK when testing with OCIS. You set the env var STORAGE_DRIVER in the drone pipeline step that runs the test scenarios, so that it knows which storage driver is being used on the system-under-test. Then the test code can make an informed decision about what extra "manual" cleanup of users it needs to do.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information