Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Bump commit id #1984

Merged
merged 1 commit into from
Apr 29, 2021
Merged

[tests-only] Bump commit id #1984

merged 1 commit into from
Apr 29, 2021

Conversation

phil-davis
Copy link
Contributor

Description

core PR owncloud/core#38661 adjusted the cleanup of user files at the end of a test scenario. Define STORAGE_DRIVER in the drone step that runs the acceptance tests so that the test code knows this about the system-under-test and can do (or avoid doing) the appropriate cleanup.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Apr 29, 2021
@phil-davis phil-davis mentioned this pull request Apr 29, 2021
Closed
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis mentioned this pull request Apr 29, 2021
Closed
@phil-davis phil-davis merged commit 9ddfab8 into master Apr 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-STORAGE_DRIVER branch April 29, 2021 04:33
ownclouders pushed a commit that referenced this pull request Apr 29, 2021
@phil-davis
commit 9ddfab8
5f10eba 
Merge: 7405812 bc48e56
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Apr 29 10:18:15 2021 +0545

    Merge pull request #1984 from owncloud/bump-commit-id-STORAGE_DRIVER

    [tests-only] Bump commit id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @individual-it