You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file still has "PARENT file content" - the restore from trashbin did nothing, the original text is still in the file or
The file has the expected restored content "file to delete" and the over-written file is in the trashbin.
They each happen about 50% of the time.
Behavior (2) seems the most reasonable one.
https://drone.owncloud.com/owncloud/core/30743/4/13
The scenario is now written to expect behavior (2). That is passing abut 50% of the time.
And 50% of the time the content of the file has not been restored - the original content is still there.
https://drone.owncloud.com/owncloud/core/30744/4/13
That is another variation of behavior (2) - this time it expects both of:
a) the previous content is in the trashbin
b) the restored content is in the file
(a) is maybe not a requirement - we do not normally put an old "version" in the trashbin when it is overwritten by new content. We would usually save it in "versions"
https://drone.owncloud.com/owncloud/core/30747/4/13
I put extra sleep(5) before the checks in Then steps and still the same result - about half the time the updated content gets restored, and half the time not. So it does not seem to be a test timing issue.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #35974