Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Cleanup good scenario for trashbinRestore issue-35974 #38869

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 19, 2021

Description

This scenario is supposed to describe the desired good behavior when restoring a file to an already existing path. The existing file should be over-written with the content of the restored file.

There happens to be another side-effect on oC10 - the original file (sometimes) gets put into the trashbin. That side-effect has not been decided to be "required behavior". Maybe the original file should end up in the trashbin, maybe it should be available as an old version of the file, or maybe it should just be thrown away.

This PR removes the check "file should not exist in the trashbin". That makes the scenario suitable as a test for implementations, for example OCIS.

See more notes and discussion in #38867 and cs3org/reva#1795

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

@dpakach it will be good to get this merged into core, and to get the core commit id updated in reva and ocis. Then they will have a better "good" scenario to work with as they sort out fixing trashbin issues.

@dpakach dpakach merged commit 2d62e73 into master Jun 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjust-test-for-issue-35974 branch June 21, 2021 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants