Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oidc scopes #680

Merged
merged 6 commits into from
Aug 22, 2024
Merged

add oidc scopes #680

merged 6 commits into from
Aug 22, 2024

Conversation

case0sh
Copy link
Contributor

@case0sh case0sh commented Aug 19, 2024 •
edited by d7oc
Loading

Description

added webOIDCscope variables to helm chart

Related Issue

How Has This Been Tested?

  • test environment: k8s, k3s, oc
  • test case 1:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@case0sh case0sh requested a review from d7oc August 19, 2024 12:04
@case0sh case0sh requested a review from wkloucek August 19, 2024 15:36
@case0sh case0sh marked this pull request as ready for review August 20, 2024 12:30
d7oc
d7oc approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d7oc
Copy link
Contributor

d7oc commented Aug 22, 2024

Will merge this now. Keycloak example fix to be continued in #688

@d7oc d7oc merged commit cad32e0 into main Aug 22, 2024
1 check passed
@d7oc d7oc deleted the web-oidc-scope branch August 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7oc d7oc d7oc approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for WEB_OIDC_SCOPE
3 participants
@case0sh @d7oc @wkloucek