Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oidc scopes #680

Merged
merged 6 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions charts/ocis/docs/values-desc-table.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -678,12 +678,6 @@ a| [subs=-attributes]
a| [subs=-attributes]
`"userid"`
| Attribute mapping of for the userIDClaim. Set to `userid` if the claim specified in `...oidc.userIDClaim` holds the value of the ldap user attribute specified in `...ldap.user.schema.id`. Set to `mail` if the claim specified in `...oidc.userIDClaim` holds the value of the ldap user attribute specified in `...ldap.user.schema.mail`. Set to `username` if the claim specified in `...oidc.userIDClaim` holds the value of the ldap user attribute specified in `...ldap.user.schema.userName`.
| features.externalUserManagement.oidc.webClientID
a| [subs=-attributes]
+string+
a| [subs=-attributes]
`"web"`
| Specify the client ID which the web frontend will use
| features.gdprReport.integrations.keycloak.basePath
a| [subs=-attributes]
+string+
Expand Down Expand Up @@ -4500,6 +4494,30 @@ a| [subs=-attributes]
a| [subs=-attributes]
`""`
| URI where the feedback link points. Uses the ownCloud default href if empty.
| services.web.config.oidc.loginURL
a| [subs=-attributes]
+string+
a| [subs=-attributes]
`nil`
| Specifies the target url valid for the logged out / access denied page.
| services.web.config.oidc.postLogoutRedirectURI
a| [subs=-attributes]
+string+
a| [subs=-attributes]
`""`
| URI where to redirect the user after a logout was performed. Defaults to the URI of the login page.
| services.web.config.oidc.webClientID
a| [subs=-attributes]
+string+
a| [subs=-attributes]
`"web"`
| Specify the client ID which the web frontend will use
| services.web.config.oidc.webClientScope
a| [subs=-attributes]
+string+
a| [subs=-attributes]
`"openid profile email"`
| OIDC scopes to request during authentication to authorize access to user details. Defaults to ‘openid profile email’. Values are separated by blank. More example values but not limited to are ‘address’ or ‘phone’ etc.
| services.web.config.previewFileMimeTypes
a| [subs=-attributes]
+list+
Expand Down
15 changes: 9 additions & 6 deletions charts/ocis/docs/values.adoc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,6 @@ features:
# -- Link to the OIDC provider's user accessible account editing page. This will be shown to the user on the personal account page.
# When using Keycloak with the a realm named "ocis" this could point to eg. https://keycloak.owncloud.test/realms/ocis/account/
editAccountLink: ""
# -- Specify the client ID which the web frontend will use
webClientID: web
# -- Claim to take an unique user identifier from. It will be used to look up the user on the LDAP server.
userIDClaim: ocis.user.uuid
# -- Attribute mapping of for the userIDClaim.
Expand Down Expand Up @@ -2267,10 +2265,15 @@ services:
# -- Name of the theme you provide via `configRefs.webThemeConfigRef` and `configRefs.webThemeAssetsConfigRef`.
# If you change this when providing a custom theme, you must also change `theme.path`.
themeNameConfigRefs: "owncloud"
# URI where to redirect the user after a logout was performed. Defaults to the URI of the login page.
postLogoutRedirectURI: ""
# Specifies the target url valid for the logged out / access denied page.
loginURL:
oidc:
# -- OIDC scopes to request during authentication to authorize access to user details. Defaults to ‘openid profile email’. Values are separated by blank. More example values but not limited to are ‘address’ or ‘phone’ etc.
webClientScope: "openid profile email"
# -- Specify the client ID which the web frontend will use
webClientID: web
# -- URI where to redirect the user after a logout was performed. Defaults to the URI of the login page.
postLogoutRedirectURI: ""
# -- Specifies the target url valid for the logged out / access denied page.
loginURL:
# Defines whether one ore more filters must be set in order to list users in the Web admin settings.
userListRequiresFilter: false
# Embed mode settings
Expand Down
9 changes: 5 additions & 4 deletions charts/ocis/templates/web/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,10 @@ spec:
{{- else }}
value: {{ .Values.features.externalUserManagement.oidc.issuerURI | quote }}
{{- end }}

- name: WEB_OIDC_CLIENT_ID
value: {{ .Values.features.externalUserManagement.oidc.webClientID | quote }}
value: {{ .Values.services.web.config.oidc.webClientID | quote }}
- name: WEB_OIDC_SCOPE
value: {{ .Values.services.web.config.oidc.webClientScope | quote }}

- name: WEB_UI_THEME_SERVER
{{- if .Values.services.web.config.theme.server }}
Expand Down Expand Up @@ -132,12 +133,12 @@ spec:
value: {{ . | quote }}
{{- end }}

{{- with .Values.services.web.config.postLogoutRedirectURI }}
{{- with .Values.services.web.config.oidc.postLogoutRedirectURI }}
- name: WEB_OIDC_POST_LOGOUT_REDIRECT_URI
value: {{ . | quote }}
{{- end }}

{{- with .Values.services.web.config.loginURL }}
{{- with .Values.services.web.config.oidc.loginURL }}
- name: WEB_OPTION_LOGIN_URL
value: {{ . | quote }}
{{- end }}
Expand Down
15 changes: 9 additions & 6 deletions charts/ocis/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,6 @@ features:
# -- Link to the OIDC provider's user accessible account editing page. This will be shown to the user on the personal account page.
# When using Keycloak with the a realm named "ocis" this could point to eg. https://keycloak.owncloud.test/realms/ocis/account/
editAccountLink: ""
# -- Specify the client ID which the web frontend will use
webClientID: web
# -- Claim to take an unique user identifier from. It will be used to look up the user on the LDAP server.
userIDClaim: ocis.user.uuid
# -- Attribute mapping of for the userIDClaim.
Expand Down Expand Up @@ -2266,10 +2264,15 @@ services:
# -- Name of the theme you provide via `configRefs.webThemeConfigRef` and `configRefs.webThemeAssetsConfigRef`.
# If you change this when providing a custom theme, you must also change `theme.path`.
themeNameConfigRefs: "owncloud"
# URI where to redirect the user after a logout was performed. Defaults to the URI of the login page.
postLogoutRedirectURI: ""
# Specifies the target url valid for the logged out / access denied page.
loginURL:
oidc:
# -- OIDC scopes to request during authentication to authorize access to user details. Defaults to ‘openid profile email’. Values are separated by blank. More example values but not limited to are ‘address’ or ‘phone’ etc.
webClientScope: "openid profile email"
# -- Specify the client ID which the web frontend will use
webClientID: web
# -- URI where to redirect the user after a logout was performed. Defaults to the URI of the login page.
postLogoutRedirectURI: ""
# -- Specifies the target url valid for the logged out / access denied page.
loginURL:
# Defines whether one ore more filters must be set in order to list users in the Web admin settings.
userListRequiresFilter: false
# Embed mode settings
Expand Down
4 changes: 3 additions & 1 deletion deployments/external-user-management/helmfile.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,6 @@ releases:
adminUUID: "ddc2004c-0977-11eb-9d3f-a793888cd0f8"
oidc:
issuerURI: https://keycloak.kube.owncloud.test/realms/oCIS
webClientID: web
userIDClaim: ocis.user.uuid
userIDClaimAttributeMapping: userid

Expand Down Expand Up @@ -392,6 +391,9 @@ releases:
web:
persistence:
enabled: true
config:
oidc:
webClientID: web
d7oc marked this conversation as resolved.
Show resolved Hide resolved

- extraResources:
- |
Expand Down