-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
PVince81
commented
Sep 11, 2020
•
edited by kulmann
Loading
edited by kulmann
- BLOCKED by make steps that check the PROPFIND response less specific #471 causing random test failures
cc70511 "Automated changelog update [skip ci]" appeared in master just now, causing GitHub to complain about this PR "This branch is out-of-date with the base branch" |
we can merge anyway, after that there will be yet another changelog generation |
Huh, weird... now the four tests I excluded in the other PR are passing... |
77640fc
to
f28ad0f
Compare
I've rebased again and removed the 4 expected failures... I hope these are not random 🙈 |
They are random. An example "fail" from a past run is:
I think this issue: #471
The test steps assume a particular order of the folder and files in the PROPFIND response. That order is consistent in oC10 and with the OCIS "oc" storage. But this new OCIS "ocis" storage seems to send a more "random" order of files in the PROPFIND response. The different order probably is acceptable - I doubt that the PROPFIND spec requires a particular sorted order of entries in the response. So we need to make the test code more flexible. How quickly to we need to do that!? |
I heard that Golang was shuffling the order of hash maps when iterating, this might explain the random order. @butonic should we sort the properties before returning ? or use another container ? |
No rush, but would be good to have this beginning of next week so we can tag "ocis". The tests are green now but I'm unsure whether we should merge in this state... |
@phil-davis the tests seem to be a bit too low level. Instead of "Then the value of the item "//d:response[1]/d:href"" would likely better to say something like "there is an entry with href XYI in the response" |
We already merged in But yes, we should not pull this into |
converted to draft as I understand, the test in question is just doing a PROPFIND, we certainly have better ways to check whether a folder contents ?? |
Test is improved in core PR owncloud/core#37902 |
I have bumped the core commit id to get the new more-reliable core tests. |