Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Make PROPFIND response href test checks more flexible #37902

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 11, 2020

Description

Make a more generic test step for checking for entries of files in a PROPFIND of a folder.
The step is more flexible so that the files do not have to be in a specific sorted order - they can be in any order in the list of files in the response.

Related Issue

How Has This Been Tested?

CI and local test runs

PR owncloud/ocis-reva#474 to demonstrate this passes in owncloud/ocis-reva

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

);

$index = 0;
while (true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you could have used a "do...while" here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I didn't revisit the loop at the end of coding. As it turned out the test+break is at the end of the loop, so do-while would have worked. For now I will leave it as-is - we want to get this in and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make steps that check the PROPFIND response less specific
2 participants