Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <oc:privatelink> property available in PROPFIND #4545

Closed
michaelstingl opened this issue Sep 8, 2022 · 1 comment · Fixed by #4590
Closed

Make <oc:privatelink> property available in PROPFIND #4545

michaelstingl opened this issue Sep 8, 2022 · 1 comment · Fixed by #4590
Assignees
Labels
Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker

Comments

@michaelstingl
Copy link
Contributor

Is your feature request related to a problem? Please describe.

ownCloud desktop sync client with oC10 can open every file or folder in the web UI. Therefore it PROPFIND with 'Depth: 0' to get the <oc:privatelink> property. This doesn't work with oCIS yet.

Describe the solution you'd like

Make <oc:privatelink> property available in PROPFIND, similar to oC10.

Desktop sync clients respect the privateLinks capability, so it must be added there too. Then it will "just work". (owncloud/client#8998)

Describe alternatives you've considered

I thought about QuickLink creation, but not every user has the permission to do so.

Additional context

oC10 PROPFIND

% curl -u test:test \
 -H 'Depth: 0' \
 -X PROPFIND https://demo.owncloud.org/remote.php/dav/files/test/Photos -d '<?xml version="1.0" encoding="utf-8"?><d:propfind xmlns:d="DAV:"><d:prop><privatelink xmlns="http://owncloud.org/ns"/></d:prop>M</d:propfind>' | xmllint --format - 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   494  100   353  100   141   1381    551 --:--:-- --:--:-- --:--:--  1991
<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/remote.php/dav/files/test/Photos/</d:href>
    <d:propstat>
      <d:prop>
        <oc:privatelink>https://demo.owncloud.org/f/20</oc:privatelink>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

oC10 capabilities

 % curl -u test:test 'https://demo.owncloud.org/ocs/v1.php/cloud/capabilities?format=json' | jq '.ocs.data.capabilities.files'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2167  100  2167    0     0   9962      0 --:--:-- --:--:-- --:--:-- 10221
{
  "privateLinks": true,
  "privateLinksDetailsParam": true,
  "bigfilechunking": true,
  "blacklisted_files": [
    ".htaccess"
  ],
  "blacklisted_files_regex": "\\.(part|filepart)$",
  "favorites": true,
  "file_locking_support": true,
  "file_locking_enable_file_action": false,
  "undelete": true,
  "versioning": true
}

@micbar @kulmann

@micbar micbar added Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker GA-Blocker labels Sep 14, 2022
@micbar micbar added this to the 2.0.0 General Availability milestone Sep 14, 2022
@micbar micbar self-assigned this Sep 14, 2022
@michaelstingl
Copy link
Contributor Author

Separate PR to bring back the capability: #4599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants