enable private links #4599
enable private links #4599
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
micbar
force-pushed
the
privatelink-capability
branch
from
4f26a40
to
29b5c97
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Just to be clear: this will show the private link copy button in the right sidebar for each and every file in the web ui. Do we need some config.json option to prevent the web ui from showing the button? We need the capability for e.g. the desktop client. But the web ui behaves according to the capability as well. cc @pmaier1 @tbsbdr
| @@ -0,0 +1,5 @@ | |||
| Change: Enable privatelinks by default | |||
There was a problem hiding this comment.
Why is this a breaking change? IMO only an enhancement.
There was a problem hiding this comment.
why is change always breaking?
There was a problem hiding this comment.
Because the classification in calens maps very well to semver like that:
SecurityandBugfixforPatchversion incrementEnhancementforMinorversion incrementChangeforMajorversion increment
Has been used in all web related repos like that since at least 1,5 years now. If not being used like that I don't understand the difference between Change and Enhancement to be honest. 😅
Same opinion. But since web respects the capabilities we'd need to add another config option in web to hide the private link copy button (which is ok). |
|
will not be merged. We do not enable the feature user-facing. |
|
@michaelstingl does the desktop client need the private link capability? Or will it only check the presence of a private link prop in propfind responses? As of now, ocis has the private-link prop in propfind responses but announces the private link capability as disabled. For web this is fine. For other clients as well? |
No. Desktop and mobile clients show the UI for the private links depending on the private-link prop. |
Description
Enable private links capability.
{ "ocs": { "meta": { "status": "ok", "statuscode": 100, "message": "OK" }, "data": { "capabilities": { "core": { "pollinterval": 60, "webdav-root": "remote.php/webdav", "status": { "installed": true, "maintenance": false, "needsDbUpgrade": false, "version": "10.11.0.0", "versionstring": "10.11.0", "edition": "Community", "productname": "Infinite Scale", "product": "Infinite Scale", "productversion": "2.0.0-beta.8+dev" }, "support-url-signing": true }, "checksums": { "supportedTypes": [ "sha1", "md5", "adler32" ], "preferredUploadType": "SHA1" }, "files": { "privateLinks": true, "bigfilechunking": false, "undelete": true, "versioning": true, "favorites": false, "blacklisted_files": [], "tus_support": { "version": "1.0.0", "resumable": "1.0.0", "extension": "creation,creation-with-upload", "max_chunk_size": 100000000, "http_method_override": "" }, "archivers": [ { "enabled": true, "version": "2.0.0", "formats": [ "tar", "zip" ], "archiver_url": "/archiver", "max_num_files": "10000", "max_size": "1073741824" } ], "app_providers": [ { "enabled": true, "version": "1.1.0", "apps_url": "/app/list", "open_url": "/app/open", "open_web_url": "/app/open-with-web", "new_url": "/app/new" } ] }, "dav": { "chunking": "", "trashbin": "1.0", "reports": [ "search-files" ], "chunkingParallelUploadDisabled": false }, "files_sharing": { "api_enabled": true, "resharing": true, "group_sharing": true, "auto_accept_share": true, "share_with_group_members_only": true, "share_with_membership_groups_only": true, "search_min_length": 3, "default_permissions": 22, "user_enumeration": { "enabled": true, "group_members_only": true }, "federation": { "outgoing": true, "incoming": true }, "public": { "enabled": true, "send_mail": true, "social_share": true, "upload": true, "multiple": true, "supports_upload_only": true, "password": { "enforced_for": { "read_only": false, "read_write": false, "upload_only": false }, "enforced": false }, "expire_date": { "enabled": false }, "can_edit": true, "alias": false }, "user": { "send_mail": true, "profile_picture": false, "settings": [ { "enabled": true, "version": "1.0.0" } ] } }, "spaces": { "version": "0.0.1", "enabled": true, "projects": true, "share_jail": true } }, "version": { "major": 10, "minor": 11, "micro": 0, "string": "10.11.0", "edition": "Community", "product": "Infinite Scale", "productversion": "2.0.0-beta.8+dev" } } } }Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: