Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] add web url to graph api and update reva #4590

Merged
merged 3 commits into from
Sep 15, 2022
Merged

[full-ci] add web url to graph api and update reva #4590

merged 3 commits into from
Sep 15, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Sep 15, 2022

Description

Add web URL to graph api.

Fixes: #4523
Fixes: owncloud/product#262

Example

curl -L -X GET "https://localhost:9200/graph/v1.0/me/drives/" \
-H "Authorization: Basic YWRtaW46YWRtaW4="
{
    "value": [
        {
            "driveAlias": "personal/admin",
            "driveType": "personal",
            "id": "1284d238-aa92-42ce-bdc4-0b0000009157$some-admin-user-id-0000-000000000000",
            "lastModifiedDateTime": "2022-09-13T23:19:02.486808+02:00",
            "name": "Admin",
            "owner": {
                "user": {
                    "id": "some-admin-user-id-0000-000000000000"
                }
            },
            "quota": {
                "remaining": 9888362496,
                "state": "normal",
                "total": 0,
                "used": 3146459
            },
            "root": {
                "eTag": "\"d654495040600828a17594d6041a7454\"",
                "id": "1284d238-aa92-42ce-bdc4-0b0000009157$some-admin-user-id-0000-000000000000",
                "webDavUrl": "https://localhost:9200/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157$some-admin-user-id-0000-000000000000"
            },
            "webUrl": "https://localhost:9200/f/1284d238-aa92-42ce-bdc4-0b0000009157$some-admin-user-id-0000-000000000000"
        }
    ]
}

Update reva

Fixes: #4545
Fixes: #4357
Fixes: #4473

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 15, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar self-assigned this Sep 15, 2022
@micbar
Copy link
Contributor Author

micbar commented Sep 15, 2022

@kulmann @michaelstingl FYI

@kulmann
Copy link
Member

kulmann commented Sep 15, 2022

IMO this should not be merged at the moment. Web doesn't resolve private links for ocis / spaces, yet. Announcing the url to other clients will "unlock" features in clients which are then not supported in web.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

44.4% 44.4% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Member

kulmann commented Sep 15, 2022

IMO this should not be merged at the moment. Web doesn't resolve private links for ocis / spaces, yet. Announcing the url to other clients will "unlock" features in clients which are then not supported in web.

Discussed that we'll merge it since it's a GA blocker = the next ocis release (in this case a release candidate) will have the private link support in web, no earlier release possible. And with that the order of merging is not that important.

@micbar micbar merged commit 5c94bf8 into master Sep 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the 3-fixes branch September 15, 2022 12:10
ownclouders pushed a commit that referenced this pull request Sep 15, 2022
Merge: 810159c e092da5
Author: Michael Barz <mbarz@owncloud.com>
Date:   Thu Sep 15 14:10:17 2022 +0200

    Merge pull request #4590 from owncloud/3-fixes

    [full-ci] add web url to graph api and update reva
@ScharfViktor
Copy link
Contributor

ScharfViktor commented Sep 16, 2022

Response is without https://localhost:9200/
Screenshot 2022-09-16 at 10 46 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants