Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y improvements for IDP service & update embed.go #2309

Merged
merged 1 commit into from
Aug 2, 2021
Merged

A11y improvements for IDP service & update embed.go #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions accounts/pkg/assets/embed.go
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions changelog/unreleased/improve-idp-accessibility
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Improve IDP Login Accessibility

We have addressed the feedback from the `a11y` audit and improved
the IDP login screen accordingly.

https://github.com/owncloud/web/issues/5376
https://github.com/owncloud/web/issues/5377
251 changes: 111 additions & 140 deletions idp/pkg/assets/embed.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion idp/ui/src/components/ResponsiveScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const ResponsiveScreen = (props) => {
} = props;

const logo = withoutLogo ? null :
<img src={process.env.PUBLIC_URL + '/static/logo.svg'} className="oc-logo" alt="ownCloud"/>;
<img src={process.env.PUBLIC_URL + '/static/logo.svg'} className="oc-logo" alt="ownCloud Logo"/>;

const content = loading ? <Loading/> : (withoutPadding ? children : <DialogContent>{children}</DialogContent>);

Expand Down
2 changes: 1 addition & 1 deletion idp/ui/src/containers/Login/Login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class Login extends React.PureComponent {
id="oc-login-password"
{...extraPropsPassword}
/>
{hasError && <Typography id="oc-login-error-message" variant="subtitle2" color="error"
{hasError && <Typography id="oc-login-error-message" variant="subtitle2" component="span" color="error"
className={classes.message}>{errorMessage}</Typography>}
<div className={classes.wrapper}>
<Button
Expand Down
4 changes: 2 additions & 2 deletions onlyoffice/pkg/assets/embed.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 32 additions & 3 deletions settings/pkg/assets/embed.go
View file
Open in desktop

Large diffs are not rendered by default.