A11y improvements for IDP service & update embed.go #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
changed the title
pascalwengerter
commented
Jul 19, 2021
idp/ui/src/containers/Login/Login.js
Outdated
| @@ -106,7 +106,7 @@ class Login extends React.PureComponent { | |||
| id="oc-login-password" | |||
| {...extraPropsPassword} | |||
| /> | |||
| {hasError && <Typography id="oc-login-error-message" variant="subtitle2" color="error" | |||
| {hasError && <Typography id="oc-login-error-message" variant="subtitle2" component="label" color="error" | |||
There was a problem hiding this comment.
Think this is not 100% right, maybe a <span> is better than a label
pascalwengerter
force-pushed
the
16072021_a11y-fixes
branch
from
754a049
to
5c1e1e6
Compare
|
@kulmann should we merge this for the release next week and cherrypick the commit when going for the second a11y-audit? |
pascalwengerter
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
@pascalwengerter @kulmann Include in the release? then we should merge now. |
Good to go from my side, waiting for feedback/review from Benedikt ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge before we've figured this out in the web team => need to discuss how we can deploy these with an updated a11y-branch for the re-audit
Description
embed.gos foraccountsandsettingssince Dependabot PRs were merged but no binaries were ever addedRelated Issue