Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Bump commit ids for tests #2392

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

Description

owncloud/web#5667 added the disablePreviews tag to another test scenario, to make it reliable. This commit-id bump will include that change in the testing.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis
Copy link
Contributor Author

I made PR owncloud/core#39110 to skip the new public link share expiration test that was added to core. That test scenario is not relevant to oCIS (yet).

@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

PR owncloud/web#5630 changes the web UI and tests - "Details sidebar for multiple selection" changed both the web behavior and the tests - that is good.

But it means that we cannot just update the web commit id here, and use the latest test code. We need to also pull the latest owncloud/web app code into oCIS.

Currently this is blocked.

@phil-davis
Copy link
Contributor Author

This needs web ccode pulled into oCIS - closing here.

@phil-davis phil-davis closed this Aug 13, 2021
@phil-davis phil-davis deleted the bump-commit-id-20210813 branch August 13, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant