Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Web-648: Details sidebar for multiple selection #5630

Merged
merged 61 commits into from
Aug 12, 2021
Merged

[full-ci] Web-648: Details sidebar for multiple selection #5630

merged 61 commits into from
Aug 12, 2021

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Aug 4, 2021 •
edited by kulmann
Loading

Description

See #5164

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Todo

  • fix scrollTo behaviour
  • fix context menu actions on unselected items

@update-docs
Copy link

update-docs bot commented Aug 4, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the WEB-648-details-for-multiple-selection branch 3 times, most recently from c682ad7 to 591c684 Compare August 5, 2021 09:19
pascalwengerter
pascalwengerter previously requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor improvements, I'll cancel the CI build for now. Could I also suggest squashing some of the commits? :)

changelog/unreleased/change-add-multiple-selection-sidebar Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/SideBar.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/index.js Outdated Show resolved Hide resolved
@lookacat lookacat changed the title WIP: Web-648: Details sidebar for multiple selection Web-648: Details sidebar for multiple selection Aug 5, 2021
@lookacat lookacat force-pushed the WEB-648-details-for-multiple-selection branch 2 times, most recently from 9b5b29b to c719dc2 Compare August 5, 2021 10:15
@ownclouders
Copy link
Contributor

Results for oC10Rename https://drone.owncloud.com/owncloud/web/18019/10/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10MoveUpload https://drone.owncloud.com/owncloud/web/18019/14/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Basic https://drone.owncloud.com/owncloud/web/18019/7/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingFilePermission https://drone.owncloud.com/owncloud/web/18019/18/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISRename https://drone.owncloud.com/owncloud/web/18019/49/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/18019/11/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISFavorites https://drone.owncloud.com/owncloud/web/18019/51/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18019/24/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersRoot2 https://drone.owncloud.com/owncloud/web/18019/30/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic https://drone.owncloud.com/owncloud/web/18019/61/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicExpireAndRoles https://drone.owncloud.com/owncloud/web/18019/35/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18019/12/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18019/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10iPhoneNotifications https://drone.owncloud.com/owncloud/web/18019/44/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersRoot1 https://drone.owncloud.com/owncloud/web/18019/29/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann kulmann force-pushed the WEB-648-details-for-multiple-selection branch from eb8863c to 767ef78 Compare August 12, 2021 10:10
@ownclouders
Copy link
Contributor

Results for oC10MoveUpload https://drone.owncloud.com/owncloud/web/18228/14/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:99

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18228/46/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:99

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

18.2% 18.2% Coverage
0.8% 0.8% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18250/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/18250/63/1
The following scenarios passed on retry:

  • webUIUserJourney/journey1.feature:11

@kulmann kulmann merged commit 9c4e595 into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the WEB-648-details-for-multiple-selection branch August 12, 2021 16:58
@phil-davis phil-davis mentioned this pull request Aug 13, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Details" for multiple selected Files in the Sidebar
4 participants
@lookacat @ownclouders @pascalwengerter @kulmann