Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only][full-ci]Adjust Expected Failures #2395

Merged
merged 1 commit into from
Aug 19, 2021
Merged

[Tests-Only][full-ci]Adjust Expected Failures #2395

merged 1 commit into from
Aug 19, 2021

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Aug 13, 2021 •
edited
Loading

Description

This PR adjusts the expected failures files after the removal/fix of the tests related to the move/rename in Shares folder.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jasson99 jasson99 self-assigned this Aug 13, 2021
@jasson99 jasson99 force-pushed the adjustExpectedFailuresForReshare branch 2 times, most recently from 6ba6d37 to 5d8660a Compare August 16, 2021 12:44
@jasson99 jasson99 mentioned this pull request Aug 17, 2021
Merged
11 tasks
@jasson99 jasson99 force-pushed the adjustExpectedFailuresForReshare branch 3 times, most recently from db756cb to 6988def Compare August 19, 2021 10:11
@jasson99 jasson99 force-pushed the adjustExpectedFailuresForReshare branch from 6988def to ed86c9d Compare August 19, 2021 10:17
@phil-davis phil-davis mentioned this pull request Aug 19, 2021
Merged
11 tasks
@phil-davis
Copy link
Contributor

There was a "random" fail in unit tests - I restarted CI.

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 765f94b into master Aug 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjustExpectedFailuresForReshare branch August 19, 2021 11:55
ownclouders pushed a commit that referenced this pull request Aug 19, 2021
@phil-davis
commit 765f94b
fc803bd 
Merge: 50c37d9 ed86c9d
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Aug 19 17:40:38 2021 +0545

    Merge pull request #2395 from owncloud/adjustExpectedFailuresForReshare

    [Tests-Only][full-ci]Adjust Expected Failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@jasson99 jasson99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasson99 @phil-davis