[Tests-Only]Adjust tests according to the expected behavior in OCIS #39111
Conversation
jasson99
force-pushed
the
adjustMoveSharesTestsInOcis
branch
2 times, most recently
from
cdc7491
to
3944c7f
Compare
jasson99
requested review from
kiranparajuli589,
dpakach,
SwikritiT,
Talank and
individual-it
tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareUpdateToShares/updateShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareReshareToShares2/reShareChain.feature
Outdated
Show resolved
Hide resolved
jasson99
force-pushed
the
adjustMoveSharesTestsInOcis
branch
from
3944c7f
to
d1f2644
Compare
| @@ -63,6 +63,41 @@ Feature: sharing | |||
| | 1 | 100 | | |||
| | 2 | 200 | | |||
|
|
|||
|
|
|||
| @issue-ocis-1289 @skipOnOcV10 | |||
There was a problem hiding this comment.
why do we skip this on oc10?
There was a problem hiding this comment.
I have removed the skipOnOc tag now. I had skipped it thinking the scenarios were almost same, but there is no harm in running in oc10 as the test passes there.
| And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/textfile0.txt" | ||
| And user "Alice" has shared file "textfile0.txt" with group "grp1" | ||
| And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" | ||
| And user "Brian" has created folder "/FOLDER" |
There was a problem hiding this comment.
that folder is never used for anything in the test
There was a problem hiding this comment.
yes, it was a mistake. I have fixed it now.
| @@ -63,6 +63,41 @@ Feature: sharing | |||
| | 1 | 100 | | |||
| | 2 | 200 | | |||
|
|
|||
|
|
|||
| @issue-ocis-1289 @skipOnOcV10 | |||
| Scenario Outline: keep group permissions in sync | |||
There was a problem hiding this comment.
I don't understand what we are trying to test here, could you please explain
There was a problem hiding this comment.
the above scenario actually tests that when a share which is moved to another folder by the receiver, and then when the sharer updates the share permission, the share permission is updated as expected. But since moving the share outside a shares folder, or even creating a new folder inside shares folder is not going to be implemented in ocis, I recreated a similar scenario where the share is just renamed instead of trying to move to some other folder.
| @files_sharing-app-required | ||
| @issue-ocis-reva-34 | ||
| @files_sharing-app-required @issue-ocis-reva-34 |
There was a problem hiding this comment.
do we really want to do that? That will mess up more lines in the expected to fail file
There was a problem hiding this comment.
yes, the changes has been made in expected failures, so while I am in this file, I wanted to make it uniform
jasson99
force-pushed
the
adjustMoveSharesTestsInOcis
branch
from
d1f2644
to
aae8ce1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Description
This PR adds
notToImplementOnOCIStag for the test scenarios in which the folders are to be moved/renamed from the shares folder, which are never to be implemented on ocis. For some scenarios where some changes might reproduce the expected behavior of that in ocis, required adjustments are made. Few scenarios are added for the behavior only in ocis.Related Issue
How Has This Been Tested?
Types of changes
Checklist: