Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable private links #4599

Merged
merged 1 commit into from
Nov 3, 2022
Merged

enable private links #4599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/enable-privatelinks-capability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Change: Enable privatelinks by default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a breaking change? IMO only an enhancement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is change always breaking?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the classification in calens maps very well to semver like that:

  • Security and Bugfix for Patch version increment
  • Enhancement for Minor version increment
  • Change for Major version increment

Has been used in all web related repos like that since at least 1,5 years now. If not being used like that I don't understand the difference between Change and Enhancement to be honest. 😅


Enable privatelinks by default in the capabilities.

https://github.com/owncloud/ocis/pull/4599/
2 changes: 1 addition & 1 deletion services/frontend/pkg/revaconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func FrontendConfigFromStruct(cfg *config.Config) (map[string]interface{}, error
}

filesCfg := map[string]interface{}{
"private_links": false,
"private_links": true,
"bigfilechunking": false,
"blacklisted_files": []string{},
"undelete": true,
Expand Down