Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] allow plain acceptance test output #5598

Merged
merged 2 commits into from
Feb 21, 2023
Merged

[tests-only] allow plain acceptance test output #5598

merged 2 commits into from
Feb 21, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 20, 2023 •
edited
Loading

Description

When using GitHub workflows (for example, in cs3org/reva) the acceptance test output is not being formatted nicely. There are lots of escape sequences that would normally select different colors for text. But the escape sequences are being shown, rather than rendering the colors.

This PR allows the acceptance tests to be run with plain output by defining the environment variable PLAIN_OUTPUT when running the tests. Just defining it is enough, the value does not matter.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Feb 20, 2023
@phil-davis phil-davis mentioned this pull request Feb 20, 2023
Closed
@phil-davis phil-davis marked this pull request as ready for review February 20, 2023 09:52
@phil-davis
Copy link
Contributor Author

Works in demo PR #5599

@phil-davis phil-davis mentioned this pull request Feb 20, 2023
Merged
11 tasks
@phil-davis phil-davis merged commit 7ec0e3c into master Feb 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the allow-plain-acceptance-test-output branch February 21, 2023 08:25
ownclouders pushed a commit that referenced this pull request Feb 21, 2023
@phil-davis
commit 7ec0e3c
3c80dd3 
Merge: 22f3577 213202d
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Feb 21 14:09:59 2023 +0545

    Merge pull request #5598 from owncloud/allow-plain-acceptance-test-output

    [tests-only] allow plain acceptance test output
This was referenced Feb 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @SwikritiT