Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Fix command format in tests/acceptance/run.sh #5624

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[tests-only] Fix command format in tests/acceptance/run.sh #5624

merged 1 commit into from
Feb 23, 2023

Conversation

phil-davis
Copy link
Contributor

Description

I got the assignment format wrong in PR #5598
When running acceptance tests, run.sh emits:

./tests/acceptance/run.sh: line 38: RED_COLOR: command not found
./tests/acceptance/run.sh: line 39: GREEN_COLOR: command not found
./tests/acceptance/run.sh: line 40: YELLOW_COLOR: command not found

There should not be spaces around the = assignment operator.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Feb 22, 2023
@phil-davis phil-davis mentioned this pull request Feb 22, 2023
Merged
@phil-davis phil-davis merged commit 804d177 into master Feb 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-acceptance-test-run-sh branch February 23, 2023 03:42
ownclouders pushed a commit that referenced this pull request Feb 23, 2023
@phil-davis
commit 804d177
1b971ab 
Merge: 4591c7e 3bad728
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Feb 23 09:27:36 2023 +0545

    Merge pull request #5624 from owncloud/fix-acceptance-test-run-sh

    [tests-only] Fix command format in tests/acceptance/run.sh
@vascoguita vascoguita mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @SwikritiT