[docs-only] wait for collabora to start before trying to register app #8144
Conversation
| @@ -127,6 +127,9 @@ services: | |||
| logging: | |||
| driver: "local" | |||
| restart: always | |||
| depends_on: | |||
| collabora: | |||
| condition: service_healthy | |||
There was a problem hiding this comment.
This is only part of V2, right? V3 https://docs.docker.com/compose/compose-file/compose-file-v3/#depends_on doesn't mention it.
There was a problem hiding this comment.
That is true, I've deleted the condition and added a check in the command.
Is that the way to achieve the waiting?
| command: app-provider server | ||
| entrypoint: | ||
| - /bin/sh | ||
| command: ["-c", "curl -k --fail https://${COLLABORA_DOMAIN:-collabora.owncloud.test} || exit 1 && ocis app-provider server" ] |
There was a problem hiding this comment.
looks quite similar to what we already have inhttps://github.com/owncloud/ocis/blob/master/deployments/examples/ocis_wopi/config/ocis-appprovider-onlyoffice/entrypoint-override.sh
Could that be reused?
|
| @@ -209,6 +214,13 @@ services: | |||
| logging: | |||
| driver: "local" | |||
| restart: always | |||
| healthcheck: | |||
There was a problem hiding this comment.
Does it make sense to use the healthcheck at all? Does depends_on respect healthcheck?
If it works, we also should add it for the onlyoffice.
|
I think this can be closed. |
Description
the apps were not always registered in the UI for me, restarting ocis-appprovider-collabora fixes the problem, so I've added a health-check and a depends condition, to make it reliable
Test together with #8143 because there are other issues
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: