-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use docker healthcheck #8984
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
5fa098c
to
de86f4f
Compare
Quality Gate passedIssues Measures |
depends_on: | ||
- ocis | ||
ocis: | ||
condition: service_started | ||
collabora: | ||
condition: service_healthy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also #8144 (comment)
This is only part of V2, right? V3 https://docs.docker.com/compose/compose-file/compose-file-v3/#depends_on doesn't mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, actually the GO version of docker-compose seems to have it!??? https://docs.docker.com/compose/compose-file/05-services/#long-syntax-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local tests show this is working .... 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running docker 26.1.0
@DeepDiver1975 Let us give it a try. |
fix: use docker healthcheck
Description
Trying to fix #8474 without docker user 0
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: