Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit-tests-only] move typescript tests to unit folder #5412

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jun 29, 2021

Description

move tests to unit test folder, following the pattern set by #5224 and finally decided by #5425

fixes #5471

after this PR all spec files should be in the right place:

find -name *spec.* | grep -v node_modules
./packages/web-pkg/tests/unit/utils/encodePath.spec.ts
./packages/web-pkg/tests/unit/utils/objectKeys.spec.ts
./packages/web-pkg/tests/unit/observer/visibility.spec.ts
./packages/web-pkg/tests/unit/cache/cache.spec.ts
./packages/web-pkg/tests/unit/http/client.spec.ts
./packages/web-app-files/tests/unit/views/Favorites.spec.js
./packages/web-app-files/tests/unit/mixins.spec.js
./packages/web-app-files/tests/unit/mixins/collaborators.spec.js
./packages/web-app-files/tests/unit/services/client.spec.ts
./packages/web-app-files/tests/unit/services/cache.spec.ts
./packages/web-app-files/tests/unit/store/mutations.spec.js
./packages/web-app-files/tests/unit/store/getters.spec.js
./packages/web-app-files/tests/unit/helpers/path.spec.js
./packages/web-app-files/tests/unit/helpers/user/avatarUrl.spec.ts
./packages/web-app-files/tests/unit/helpers/share/triggerShareAction.spec.js
./packages/web-app-files/tests/unit/helpers/resource/asset.spec.ts
./packages/web-app-files/tests/unit/helpers/resource/common.spec.ts
./packages/web-app-files/tests/unit/helpers/resource/privatePreviewBlob.spec.ts
./packages/web-app-files/tests/unit/helpers/resource/publicPreviewUrl.spec.ts
./packages/web-app-files/tests/unit/components/AppBar/SelectedResources/BatchActions.spec.js
./packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js
./packages/web-app-files/tests/unit/components/AppBar/Upload/FileUpload.spec.js
./packages/web-app-files/tests/unit/components/SideBar/Shares/Collaborators/ShowCollaborator.spec.js
./packages/web-app-files/tests/unit/components/SideBar/Shares/Collaborators/AutocompleteItem.spec.js
./packages/web-app-files/tests/unit/components/SideBar/Details/FileDetails.spec.js
./packages/web-app-files/tests/integration/specs/pagination.spec.js
./packages/web-runtime/tests/unit/mixins/lifecycleMixin.spec.js
./packages/web-runtime/tests/unit/mixins/focusMixin.spec.js
./packages/web-runtime/tests/unit/store/config.spec.js
./packages/web-runtime/tests/unit/helpers/config.spec.js
./packages/web-runtime/tests/unit/helpers/resource.spec.js
./packages/web-runtime/tests/unit/helpers/theme.spec.js
./packages/web-runtime/tests/unit/components/Notification.spec.js
./packages/web-runtime/tests/unit/components/UserMenu.spec.js
./packages/web-runtime/tests/unit/components/__snapshots__/TopBar.spec.js.snap
./packages/web-runtime/tests/unit/components/SidebarQuota.spec.js
./packages/web-runtime/tests/unit/components/TopBar.spec.js

Motivation and Context

fixing sonar cloud coverage report

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it
Copy link
Member Author

according to a talk in the chat it's not fully decided yet if there's a dedicated tests folder or tests should live side-by-side with their respective files
feel free to comment in this PR or to refuse it, we can also adjust the sonarcloud config to ignore *spec* files in the count of the coverage

@pascalwengerter
Copy link
Contributor

@fschade @kulmann we need a decision on where to store test files since currently it's not standardized. @LukasHirt made a great argument here, I'm undecided but we should align it once and stick to it :)

@individual-it
Copy link
Member Author

the discussion was opened by @fschade here #5425 please give you input

@individual-it
Copy link
Member Author

I've updated the original comment, please review again

@individual-it individual-it mentioned this pull request Jul 8, 2021
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit 229b8cb into master Jul 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the moveTests branch July 8, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify test locations
3 participants