Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit-tests-only] ignore mocks and fixtures for coverage #5413

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

individual-it
Copy link
Member

Description

ignore test related files for sonar cloud analysis
maybe they could also be moved into the tests folder and by that they would be ignored altogether see #5412

Motivation and Context

correct sonarcloud coverage report

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@individual-it individual-it merged commit 2fe29b3 into master Jun 29, 2021
@pascalwengerter pascalwengerter deleted the ignoreMockForCoverage branch June 30, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants