Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y #5381 table role presentation for version table #5567

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

lookacat
Copy link
Contributor

Description

See #5381

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jul 26, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the a11y-#5381-table-role-presentation branch from b344dd0 to 3c237cd Compare July 26, 2021 12:29
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting needs to be fixed. Please add a bugfix changelog item. ;-)

@lookacat lookacat force-pushed the a11y-#5381-table-role-presentation branch from a35216c to 9616618 Compare July 30, 2021 09:14
@lookacat
Copy link
Contributor Author

Added changelog, the linting makes no sence, local linter doesn't show errors and the file doesnt have that line of code...

@pascalwengerter pascalwengerter merged commit 121ef6a into a11y-updates Aug 2, 2021
@pascalwengerter
Copy link
Contributor

I'll ignore CI/linting errors for now and merge this into the intermediate a11y-updates branch

@pascalwengerter pascalwengerter deleted the a11y-#5381-table-role-presentation branch August 3, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants