-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] fix: escape image name in media viewer #5655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🐞
This comment has been minimized.
This comment has been minimized.
1c4f3dc
to
e5a3e2c
Compare
Kudos, SonarCloud Quality Gate passed! |
Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18151/28/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18151/12/1
|
@kulmann How to proceed with this? Force merge? Wait for QA teams changes, rebase and see if it helps? |
I'll force-merge ;-) The CI only had |
We've started escaping the file name in the Media viewer extension so that a file with special characters in the name can still be loaded.