Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] fix: escape image name in media viewer #5655

Merged
merged 1 commit into from
Aug 11, 2021
Merged

[full-ci] fix: escape image name in media viewer #5655

merged 1 commit into from
Aug 11, 2021

Conversation

LukasHirt
Copy link
Collaborator

We've started escaping the file name in the Media viewer extension so that a file with special characters in the name can still be loaded.

@LukasHirt LukasHirt self-assigned this Aug 10, 2021
@LukasHirt LukasHirt added the Type:Bug Something isn't working label Aug 10, 2021
kulmann
kulmann approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🐞

@ownclouders

This comment has been minimized.

Sign in to view
@LukasHirt LukasHirt changed the title fix: escape image name in media viewer [full=ci] fix: escape image name in media viewer Aug 10, 2021
@LukasHirt LukasHirt changed the title [full=ci] fix: escape image name in media viewer [full-ci] fix: escape image name in media viewer Aug 10, 2021
@LukasHirt LukasHirt force-pushed the fix/preview-image-with-special-chars branch from 1c4f3dc to e5a3e2c Compare August 10, 2021 14:13
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18151/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18151/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@LukasHirt
Copy link
Collaborator Author

@kulmann How to proceed with this? Force merge? Wait for QA teams changes, rebase and see if it helps?

@kulmann
Copy link
Member

kulmann commented Aug 11, 2021

@kulmann How to proceed with this? Force merge? Wait for QA teams changes, rebase and see if it helps?

I'll force-merge ;-) The CI only had webUIUpload/upload.feature:90 failing, which is a known flaky test.

@kulmann kulmann merged commit bda8963 into master Aug 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/preview-image-with-special-chars branch August 11, 2021 13:53
@fschade fschade mentioned this pull request Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@LukasHirt LukasHirt

Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

media viewer does not handle special characters
3 participants
@LukasHirt @ownclouders @kulmann