Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit-tests] added unit tests for SharedWithMe view #5722

Closed

Conversation

kiranparajuli589
Copy link
Contributor

Description

  • added unit tests for 'SharedWithMe` view
    (will be rebased after the dependent branch is merged on master)

Related Issue

How Has This Been Tested?

  • yarn test:unit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@update-docs
Copy link

update-docs bot commented Aug 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18528/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18600/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@kiranparajuli589 kiranparajuli589 force-pushed the test-share-with-me-view branch 4 times, most recently from 06b30d6 to b49af51 Compare August 26, 2021 17:48
@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 3 times, most recently from 39dbaf3 to f54b8d3 Compare September 1, 2021 04:45
@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 2 times, most recently from a20e887 to f44caea Compare September 15, 2021 11:42
@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 3 times, most recently from 9b66943 to 765e38b Compare September 22, 2021 10:12
@pascalwengerter
Copy link
Contributor

@kiranparajuli589 could you split this one up in multiple PRs all covering individual components, please? Otherwise it's really hard to review (and thus will take longer to merge)

@pascalwengerter
Copy link
Contributor

@individual-it this seems like @kiranparajuli589 branched it off from other branches that contain different files. Could you take a look and extract the relevant files and either rebase this PR or open a new one? :) Thanks!

@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 3 times, most recently from 673e6b5 to c88b4f2 Compare December 8, 2021 04:13
@kiranparajuli589
Copy link
Contributor Author

@individual-it this seems like @kiranparajuli589 branched it off from other branches that contain different files. Could you take a look and extract the relevant files and either rebase this PR or open a new one? :) Thanks!

@pascalwengerter, there was some changed code in views.setup.js which was also useful here. Can we chain this PR with unittest-views-location-picker. This will be in draft until the base PR is merged to the master?

@pascalwengerter
Copy link
Contributor

@kiranparajuli589 that's great news! Could I still ask you to split up this PR into separate ones based on the tested views? I'm not really keen on reviewing a ~2.000 line PR 🥴

@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Dec 9, 2021

@kiranparajuli589 that's great news! Could I still ask you to split up this PR into separate ones based on the tested views? I'm not really keen on reviewing a ~2.000 line PR woozy_face

yes sure :), actually tests for SharedWithMe view is already done, so the PR title is also not correct now.

remaining views to test:

  • SharedWithOthers
  • Trashbin
  • PublicFiles
    also see issue for more details

If it's good to add tests for these views now, I can add them (in separate PRs).

@kiranparajuli589
Copy link
Contributor Author

closed because the tests will be splitted for different views

@pascalwengerter
Copy link
Contributor

@kiranparajuli589 thanks for updating this PR. Could I ask you to do the splitting and open separate PRs for the applicable views?

@pascalwengerter pascalwengerter deleted the test-share-with-me-view branch December 22, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants