-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unit-tests] added unit tests for SharedWithMe view #5722
[unit-tests] added unit tests for SharedWithMe view #5722
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18528/46/1 |
cd8dcb6
to
4ecaa2b
Compare
2850d6e
to
59a789b
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18600/12/1
|
4ecaa2b
to
42bf734
Compare
06b30d6
to
b49af51
Compare
39dbaf3
to
f54b8d3
Compare
4032326
to
4e5af2a
Compare
a20e887
to
f44caea
Compare
9b66943
to
765e38b
Compare
765e38b
to
daa1242
Compare
@kiranparajuli589 could you split this one up in multiple PRs all covering individual components, please? Otherwise it's really hard to review (and thus will take longer to merge) |
@individual-it this seems like @kiranparajuli589 branched it off from other branches that contain different files. Could you take a look and extract the relevant files and either rebase this PR or open a new one? :) Thanks! |
673e6b5
to
c88b4f2
Compare
@pascalwengerter, there was some changed code in |
c88b4f2
to
a2ed0fe
Compare
@kiranparajuli589 that's great news! Could I still ask you to split up this PR into separate ones based on the tested views? I'm not really keen on reviewing a ~2.000 line PR 🥴 |
4e5af2a
to
e70a6ea
Compare
yes sure :), actually tests for remaining views to test:
If it's good to add tests for these views now, I can add them (in separate PRs). |
closed because the tests will be splitted for different views |
@kiranparajuli589 thanks for updating this PR. Could I ask you to do the splitting and open separate PRs for the applicable views? |
Description
(will be rebased after the dependent branch is merged on master)
Related Issue
How Has This Been Tested?
yarn test:unit
Types of changes
Checklist:
Open tasks: