[full-ci] Switch upload logic to Uppy #6202

pascalwengerter · 2021-12-30T08:27:11Z

Description

We've implemented Uppy as a library for handling uploads. This concludes the following features and changes:

Resumable uploads when the backend supports the Tus-protocol
A nice looking overview for all files that have been uploaded successfully or failed to upload
Navigation across Web while uploads are in progress
Improved rendering of uploadProgress-visualization
Removed vue2-dropzone and vue-drag-drop libraries

Related Issue

Fixes Make file upload reliable #6268
Fixes tbd (maybe there's more)

Screenshots

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

Open tasks/enhancements: #6819

pascalwengerter · 2022-03-28T22:33:07Z

I've rebased this PR on #6662 since simplifying the AppBar made the switch to Uppy way easier (we can&should change PR targets back to master once #6662 is merged, obviously). There's a couple of pitfalls and decisions to take still, but confident that the codebase & project profits even from merging a "simpler" version (e.g. without "Resume" button")

ownclouders · 2022-03-28T22:40:20Z

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/24948/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L227.png

changelog/unreleased/enhancement-resumeable-uploads

packages/web-app-files/package.json

dschmidt

🥳👏🎉

This is very nice!

It has a bunch of rough edges, we might want to move things around a bit still (and I would like to hear opinions of the others), but I feel we're heading in the right direction. I'm only worried that composables and the service interaction/relation feel slightly chaotic still... not sure yet, how we can improve that

Most of the comments I left are basically reminders for myself, so we can talk about it again.

Bare with my typos and rather short sentences, I am typing on my phone 😅

dschmidt · 2022-04-13T20:20:51Z

packages/web-app-files/src/components/AppBar/CreateAndUpload.vue

+      await this.createDirectoryTree(files)
+      await this.updateStoreForCreatedFolders(files)
+      this.$uppyService.uploadFiles(files)
+    },


I'm not so happy with this, it kind of feels the service should handle this - but we have so many dependencies here that are weird to get in a service... totally unsure about that.

At least we can move this function to the composable.

packages/web-app-files/src/components/AppBar/Upload/FileUpload.vue

dschmidt · 2022-04-13T20:28:09Z

packages/web-app-files/src/composables/upload/useUploadHelpers.ts

+      publicLinkPassword
+    }),
+    currentPath,
+    uploadPath


I see good reasons for having currentPath and uploadPath computed in the composable vs having them passed in.... not sure

A good reason for it being passed to the composable is that those props might vary. The FileDrop component e.g. has a completely other upload path.

dschmidt · 2022-04-13T20:31:31Z

packages/web-app-files/src/composables/upload/useUploadHelpers.ts

+      const storageId = params.storageId
+      const webDavPath = storageId
+        ? buildWebDavSpacesPath(storageId, `${currentFolder}${directory}`)
+        : buildWebDavFilesPath(unref(user)?.id, `${currentFolder}${directory}`)


I'm wondering... what should happen if the unref'ed user is null or undefined? We might error out early as well, no?

packages/web-app-files/src/composables/upload/useUploadHelpers.ts

packages/web-runtime/src/composables/upload/useUpload.ts

packages/web-runtime/src/services/uppyService.ts

dschmidt · 2022-04-14T07:00:48Z

packages/web-runtime/src/services/uppyService.ts

+import { UppyResource } from '../composables/upload'
+import Vue from 'vue'
+
+export class UppyService extends Vue {


We used this as a quick hack, to port away from events on the $root instance. Do we have a better provider for the $on, $off and $emit functionality. EventBus maybe?

packages/web-app-files/src/components/AppBar/CreateAndUpload.vue

dschmidt

Okay for now, but please check my remaining comments in the follow up ticket/PRs

dschmidt · 2022-04-27T14:31:24Z

packages/web-runtime/src/container/bootstrap.ts

@@ -249,6 +250,15 @@ export const announceClientService = ({
  vue.prototype.$clientService.owncloudSdk = sdk
 }

+/**
+ * announce uppyService and owncloud SDK and inject it into vue


no owncloud SDK here

sonarcloud · 2022-04-27T16:15:29Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
4 Security Hotspots
16 Code Smells

20.8% Coverage
0.0% Duplication

dschmidt · 2022-04-27T20:17:11Z

🎉 🥳 👏🏻 🥳 🎉

pascalwengerter requested review from fschade and kulmann as code owners December 30, 2021 08:27

pascalwengerter marked this pull request as draft December 30, 2021 08:27

pascalwengerter force-pushed the uppy-poc branch from 4350fbf to 9c8a40d Compare March 28, 2022 22:29

pascalwengerter changed the base branch from master to simplify-appbar March 28, 2022 22:29

pascalwengerter force-pushed the simplify-appbar branch from 64e7cf4 to 4a29b02 Compare March 28, 2022 22:37

pascalwengerter force-pushed the uppy-poc branch 2 times, most recently from 365aef6 to a0e8e35 Compare March 29, 2022 07:27

pascalwengerter force-pushed the simplify-appbar branch 3 times, most recently from 49688aa to 30def9c Compare March 29, 2022 16:06

delete-merged-branch bot deleted the branch master March 29, 2022 16:38

pascalwengerter changed the base branch from simplify-appbar to master March 29, 2022 17:11

pascalwengerter force-pushed the uppy-poc branch 4 times, most recently from c8e71ce to a866a98 Compare April 4, 2022 09:11

JammingBen force-pushed the uppy-poc branch 2 times, most recently from e27ed15 to d4143c1 Compare April 11, 2022 13:57

pascalwengerter commented Apr 13, 2022

View reviewed changes

changelog/unreleased/enhancement-resumeable-uploads Outdated Show resolved Hide resolved

pascalwengerter commented Apr 13, 2022

View reviewed changes

packages/web-app-files/package.json Outdated Show resolved Hide resolved

JammingBen force-pushed the uppy-poc branch from 81aec9f to fe6de94 Compare April 13, 2022 13:29

JammingBen changed the title ~~Switch upload logic to Uppy~~ [full-ci] Switch upload logic to Uppy Apr 13, 2022

JammingBen force-pushed the uppy-poc branch from f55be50 to 6b99435 Compare April 13, 2022 14:14

dschmidt requested changes Apr 13, 2022

View reviewed changes

dschmidt reviewed Apr 14, 2022

View reviewed changes

owncloud deleted a comment from update-docs bot Apr 14, 2022

pascalwengerter force-pushed the uppy-poc branch from 029b1e6 to b0dbdd0 Compare April 22, 2022 09:11

JammingBen added 6 commits April 27, 2022 15:01

Fix issue with missing slashes when uploading

52934d6

Ensure that uppy uses only one upload plugin at a time

99aba33

Fix issue when updating the store for newly created folders

495aa91

Remove Uppy debug state

ae25b61

Small fixes and polishing

f887105

Fix tests, polishing

af1bc4b

JammingBen force-pushed the uppy-poc branch from 322dab9 to af1bc4b Compare April 27, 2022 13:01

JammingBen marked this pull request as ready for review April 27, 2022 13:59

pascalwengerter mentioned this pull request Apr 27, 2022

Add content to file in Folder,with,coma owncloud/owncloud-test-middleware#109

Merged

JammingBen added 2 commits April 27, 2022 16:19

Undo change in sunday,monday.txt file

e38c3a2

Bump owncloud-test-middleware docker image version to 1.5.0

9198b07

pascalwengerter commented Apr 27, 2022

View reviewed changes

packages/web-app-files/src/components/AppBar/CreateAndUpload.vue Show resolved Hide resolved

dschmidt approved these changes Apr 27, 2022

View reviewed changes

pascalwengerter mentioned this pull request Apr 27, 2022

"Buffer is not defined" in typescript files #6821

Closed

pascalwengerter merged commit 2b91812 into master Apr 27, 2022

delete-merged-branch bot deleted the uppy-poc branch April 27, 2022 17:40

pascalwengerter mentioned this pull request May 3, 2022

Do you use Uppy? transloadit/uppy#769

Open

JammingBen mentioned this pull request May 4, 2022

[tests-only] Add unit tests for the uppy implementation #6871

Merged

micbar mentioned this pull request May 5, 2022

Release 2.0.0-beta1 owncloud/ocis#3627

Closed

45 tasks

pascalwengerter mentioned this pull request May 5, 2022

uploading many files freeze the browser #5882

Closed

JammingBen mentioned this pull request May 6, 2022

Enable tus upload for password protected public links #6890

Merged

pascalwengerter mentioned this pull request May 6, 2022

Can't edit collaborators while file uploads are in progress #5031

Closed

kulmann mentioned this pull request May 9, 2022

Upload in file-drop public link flattens folder hierarchy #2443

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Switch upload logic to Uppy #6202

[full-ci] Switch upload logic to Uppy #6202

pascalwengerter commented Dec 30, 2021 •

edited

Loading

pascalwengerter commented Mar 28, 2022

ownclouders commented Mar 28, 2022 •

edited

Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L227.png

dschmidt left a comment •

edited

Loading

dschmidt Apr 13, 2022

dschmidt Apr 13, 2022

JammingBen Apr 14, 2022

dschmidt Apr 13, 2022 •

edited

Loading

dschmidt Apr 14, 2022

dschmidt left a comment

dschmidt Apr 27, 2022

sonarcloud bot commented Apr 27, 2022

dschmidt commented Apr 27, 2022

[full-ci] Switch upload logic to Uppy #6202

[full-ci] Switch upload logic to Uppy #6202

Conversation

pascalwengerter commented Dec 30, 2021 • edited Loading

Description

Related Issue

Screenshots

Types of changes

Checklist:

pascalwengerter commented Mar 28, 2022

ownclouders commented Mar 28, 2022 • edited Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L227.png

dschmidt left a comment • edited Loading

Choose a reason for hiding this comment

dschmidt Apr 13, 2022

Choose a reason for hiding this comment

dschmidt Apr 13, 2022

Choose a reason for hiding this comment

JammingBen Apr 14, 2022

Choose a reason for hiding this comment

dschmidt Apr 13, 2022 • edited Loading

Choose a reason for hiding this comment

dschmidt Apr 14, 2022

Choose a reason for hiding this comment

dschmidt left a comment

Choose a reason for hiding this comment

dschmidt Apr 27, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Apr 27, 2022

dschmidt commented Apr 27, 2022

pascalwengerter commented Dec 30, 2021 •

edited

Loading

ownclouders commented Mar 28, 2022 •

edited

Loading

dschmidt left a comment •

edited

Loading

dschmidt Apr 13, 2022 •

edited

Loading