feat: prefer alias links over private links in UI #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
approved these changes
Nov 3, 2022
kulmann
force-pushed
the
prefer-alias-links-over-private-links
branch
from
af368d6
to
e638de0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
prefer-alias-links-over-private-links
branch
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Private link capability has been merged in ocis, see owncloud/ocis#4599
The web ui is not supposed to show the
copy private linkbutton, the private link concept is only supposed to be used for cross-client links to files. The web ui concept for "file pointers" is the new alias link. Hence this PR disables the private link copy button in the web ui when the alias link capability is enabled.Types of changes
Checklist: