[full-ci] Show single (publicly) shared file in DetailsView

[pascalwengerter]

Description

Needs

• [ ] extracting components from the packages/web-app-files/src/components/Sidebar/ directory (we decided that this is not necessary for now)
• adding unit tests for the CERN/reva and the oCIS/oC10 resolving of "single shared file"
• (perhaps) updating a lot of acceptance tests (since they 1. currently expect a table and 2. IIRC there's also expected failures for this exact feature couldn't find any)

Related Issue

• Supersedes WIP Single file share view #8440
• Fixes [cern] Display single (publicly) shared _file_ in dedicated view #8445

[ownclouders]

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/35562/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35562/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-5-9-08-01-54.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35562/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-5-9-08-02-26.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35562/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-5-9-08-02-29.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35562/tracing/quick-link-alice-2023-5-9-08-06-15.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35562/tracing/quick-link-anonymous-2023-5-9-08-06-22.zip

[ownclouders]

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35562/13/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIWebdavLockProtection-delete_feature-L33.png

webUIWebdavLockProtection-delete_feature-L34.png

webUIWebdavLockProtection-move_feature-L36.png

webUIWebdavLockProtection-move_feature-L37.png

[diocas]

If you keep our original logic, you don't need to worry whether it's a share where users can upload or not and becomes as simple as a single if condition.

Basically, it's a single public share if 1) there's only 1 paginated resource and 2) there is no current folder.

Since you create a "fake space" for the current folder, you can check whether it exists or not by checking that the fileId does not exist.

So, this is enough:

      if (this.paginatedResources.length === 1 && !this.currentFolder.fileId) {
        return true
      }
      return false

(ps: for the CERN case we still need to check that this.currentFolder.path !== this.paginatedResources[0].path for the internal shares, since our webdav response is not correct.. you can put a FIXME or smth in the code, and we will remove that if our backend aligns with ocis or gets fixed)

[pascalwengerter]

Hmmm we'd still need to check whether the receiver has upload rights for the current/shared folder, right? The way it's working right now is that

• shared individual file => ResourceDetails view (creating a "fake" space)
• shared folder with single file and no upload permissions => ResourceDetails view
• shared folder with single file and upload permissions => table
• shared folder with any amount of files and upload permissions => table

Or is that going against your initial feature request?

[pascalwengerter]

@kulmann happy to receive a review here already, while figuring out the unit tests :) (acceptance tests are green)

[kulmann]

I'm a bit confused that you introduce so much options api vue code 😁 + see one comment. Works as expected and code looks good so far.

Do you want to add unit tests in a separate PR? I'd like to have them in this PR, but not sure how easy that's to resolve for you at the moment.

[kulmann]

Why the check on canUpload? 🤔

[pascalwengerter]

Because (from my understanding) we'd show the table/tiles if the share/link receiver can upload - one of the usability complaints was that users don't understand that they can't upload when seeing a single shared file in the table view.
It's more of a PO decision, we could also use the ResourceDetails.vue and enable the AppBar with create/upload buttons for single files and upload permissions, and then "switch over" to table/tiles once another resource is added.
Let me know, happy to finalize this either way :)

[diocas]

But, isn't the check of paginatedResources[0].isFolder enough? Or do you have any case where you can upload and is not a folder? (that would be strange, no?)

[kulmann]

My understanding was that we only ever show the single file view for files, never for folders. And for a file you will never be able to upload, like @diocas said. So isPublicSpaceResource(this.space) && !this.paginatedResources[0].isFolder should be sufficient.

[pascalwengerter]

@kulmann not sure if expected behavior product-wise

[pascalwengerter]

As in "you're a user on a public link, create a folder, navigate into folder, create/upload a file and see this file as a single share (and not in a table view)"

[pascalwengerter]

@kulmann not sure if expected behavior product-wise

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

64.4% Coverage
0.0% Duplication

[kulmann]

Nice!