Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Keep ItemFilter sortorder #9942

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Bugfix: Keep ItemFilter sortorder #9942

merged 6 commits into from
Nov 16, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Nov 14, 2023 •
edited
Loading

Description

See #9938

Related Issue

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Nov 14, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the bugfix-keep-itemfilter-sortorder branch from a51b26c to a3c13f0 Compare November 15, 2023 08:51
@lookacat lookacat marked this pull request as ready for review November 15, 2023 10:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat enabled auto-merge (squash) November 15, 2023 13:14
@lookacat lookacat merged commit 19af992 into master Nov 16, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix-keep-itemfilter-sortorder branch November 16, 2023 06:15
@lookacat lookacat mentioned this pull request Nov 21, 2023
Closed
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear
Bugfix: Keep ItemFilter sortorder (#9942)
f21e431 
* Bugfix: Keep ItemFilter sortorder

* Add to changelog

* Remove sort function

* Fix unittests

* Fix unittests / selectors

* use getId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filterchip order wrong if searched for item
2 participants
@lookacat @JammingBen