Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: AST changes doesn't return exit code #4929

Closed
rzvxa opened this issue Aug 15, 2024 · 0 comments · Fixed by #4930
Closed

CI: AST changes doesn't return exit code #4929

rzvxa opened this issue Aug 15, 2024 · 0 comments · Fixed by #4930
Labels
C-bug Category - Bug P-high Priority - High

Comments

@rzvxa
Copy link
Contributor

rzvxa commented Aug 15, 2024

I've changed the AST Changes CI in #4846. In that PR I've added an echo at the end which hides the actual error code.
As a result, our AST Changes CI doesn't fail on changes! Thankfully there were no mistakes in our recent PRs after that faulty change.

I have to fix this immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug P-high Priority - High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant