Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Return an error code on the failed AST Changes step. #4930

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix(ci): Return an error code on the failed AST Changes step. #4930

merged 1 commit into from
Aug 16, 2024

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Aug 15, 2024 •
edited
Loading

Closes #4929

@rzvxa Graphite App
Copy link
Contributor Author

rzvxa commented Aug 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa mentioned this pull request Aug 15, 2024
Closed
@rzvxa rzvxa force-pushed the 08-16-fix_ci_return_an_error_code_on_the_failed_ast_changes_step branch 2 times, most recently from f7088a9 to 15ed1d0 Compare August 16, 2024 00:22
@rzvxa
Copy link
Contributor Author

rzvxa commented Aug 16, 2024 •
edited
Loading

This is a severe issue so I'm merging it without review to prevent any faulty code from getting in to upstream.

@rzvxa rzvxa marked this pull request as ready for review August 16, 2024 00:28
@rzvxa rzvxa added the hotfix label Aug 16, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 16, 2024 •
edited
Loading

Merge activity

  • Aug 15, 8:28 PM EDT: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 15, 8:28 PM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Aug 15, 8:32 PM EDT: rzvxa merged this pull request with the Graphite merge queue.

@rzvxa rzvxa force-pushed the 08-16-fix_ci_return_an_error_code_on_the_failed_ast_changes_step branch from 15ed1d0 to a0b1b86 Compare August 16, 2024 00:29
@graphite-app graphite-app bot merged commit a0b1b86 into main Aug 16, 2024
15 checks passed
@graphite-app graphite-app bot deleted the 08-16-fix_ci_return_an_error_code_on_the_failed_ast_changes_step branch August 16, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: AST changes doesn't return exit code
1 participant
@rzvxa