Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): add SymbolId and ReferenceId #510

Closed
3 tasks
Boshen opened this issue Jul 3, 2023 · 3 comments · Fixed by #755
Closed
3 tasks

refactor(ast): add SymbolId and ReferenceId #510

Boshen opened this issue Jul 3, 2023 · 3 comments · Fixed by #755
Assignees
Labels
P-high Priority - High

Comments

@Boshen
Copy link
Member

Boshen commented Jul 3, 2023

This will make the linter easier to write when you need to get the binding for a given identifier reference.

This is already done for the HIR, I just need to combine the code for the AST.

@Boshen Boshen self-assigned this Jul 3, 2023
@mysteryven
Copy link
Contributor

mysteryven commented Jul 3, 2023

I may need this too: #507 (comment)

@hyf0
Copy link
Contributor

hyf0 commented Aug 15, 2023

I have met similar situation. I have to traverse the AST. With this requirement, to get the SymbolId of some identifiers, I need to get the atom of the Identifier, perform a query on ScopeTree to get SymbolId and thanks for I only care about the ids of root scope, so I don't need to search which scope the atom in.

@Boshen
Copy link
Member Author

Boshen commented Aug 19, 2023

@mysteryven You may start fixing all the issues we have accumulated 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high Priority - High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants