-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add eslint/no-obj-calls #508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Only a small change is required.
@Boshen thanks for the review, I'll address your comments. I just updated my PR to support references to global objects, e.g. // Bad
let a = JSON;
let b = a;
let c = b;
c();
let m = Math
function foo() {
new m();
}
// Good
let m = Math
function foo() {
let m = x => x;
m();
} I'd appreciate a second look if you can. |
I don't want #510 blocking this PR so I merged it. Thank you so much for the contribution! |
I know this is already merged and closed but I don't want to open a new issue when it's so recent. When running the current main branch against the
That doesn't seem like it's supposed to happen. |
@Boshen would you like me to look into this separately or will you cover this in one of your following PRs? |
A quick removal of that |
Adds support for no-obj-calls. Provides progress towards completing #479.