Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter/eslint): fix require-await false positives in ForOfStatement. #3457

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented May 28, 2024

closes #3456

Copy link

graphite-app bot commented May 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

rzvxa commented May 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label May 28, 2024
@rzvxa rzvxa marked this pull request as ready for review May 28, 2024 17:51
@rzvxa rzvxa force-pushed the 05-28-fix_linter_eslint_fix_require-await_false_positives_in_forofstatement_ branch from 00815fc to b6bcdae Compare May 28, 2024 17:52
Copy link

codspeed-hq bot commented May 28, 2024

CodSpeed Performance Report

Merging #3457 will not alter performance

Comparing 05-28-fix_linter_eslint_fix_require-await_false_positives_in_forofstatement_ (b188778) with main (64246c5)

Summary

✅ 22 untouched benchmarks

@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label May 28, 2024
Copy link

graphite-app bot commented May 28, 2024

Merge activity

  • May 28, 1:58 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 28, 1:58 PM EDT: rzvxa added this pull request to the Graphite merge queue.
  • May 28, 2:02 PM EDT: rzvxa merged this pull request with the Graphite merge queue.

@rzvxa rzvxa force-pushed the 05-28-fix_linter_eslint_fix_require-await_false_positives_in_forofstatement_ branch from b6bcdae to b188778 Compare May 28, 2024 17:58
@graphite-app graphite-app bot merged commit b188778 into main May 28, 2024
22 checks passed
@graphite-app graphite-app bot deleted the 05-28-fix_linter_eslint_fix_require-await_false_positives_in_forofstatement_ branch May 28, 2024 18:02
Boshen added a commit that referenced this pull request Jun 7, 2024
## [0.4.3] - 2024-06-07

### Features

- 1fb9d23 linter: Add fixer for no-useless-fallback-in-spread rule
(#3544) (Don Isaac)
- 6506d08 linter: Add fixer for no-single-promise-in-promise-methods
(#3531) (Don Isaac)
- daf559f linter: Eslint-plugin-jest/no-large-snapshot (#3436) (cinchen)
- 4c17bc6 linter: Eslint/no-constructor-return (#3321) (谭光志)
- 4a075cc linter/jsdoc: Implement require-param rule (#3554) (Yuji
Sugiura)
- 747500a linter/jsdoc: Implement require-returns-type rule (#3458)
(Yuji Sugiura)
- 6b39654 linter/tree-shaking: Support options (#3504) (Wang Wenzhe)
- 0cdb45a oxc_codegen: Preserve annotate comment (#3465)
(IWANABETHATGUY)

### Bug Fixes

- b188778 linter/eslint: Fix `require-await` false positives in
`ForOfStatement`. (#3457) (rzvxa)
- 350cd91 parser: Should parser error when function declaration has no
name (#3461) (Dunqing)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require-await does not seem to detect await statement in loops
1 participant