-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oxc_codegen): preserve annotate comment #3465
Merged
IWANABETHATGUY
merged 2 commits into
oxc-project:main
from
IWANABETHATGUY:feat/preserve-annotate-comment1
May 30, 2024
Merged
feat(oxc_codegen): preserve annotate comment #3465
IWANABETHATGUY
merged 2 commits into
oxc-project:main
from
IWANABETHATGUY:feat/preserve-annotate-comment1
May 30, 2024
+574
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Area - Linter
A-minifier
Area - Minifier
A-transformer
Area - Transformer / Transpiler
A-codegen
Area - Code Generation
labels
May 29, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3465 will not alter performanceComparing Summary
|
IWANABETHATGUY
force-pushed
the
feat/preserve-annotate-comment1
branch
from
May 29, 2024 16:25
531100f
to
3aca9f5
Compare
IWANABETHATGUY
changed the title
feat: 🎸 preserve annotate comment
feat: preserve annotate comment
May 29, 2024
IWANABETHATGUY
changed the title
feat: preserve annotate comment
feat(oxc_codegen): preserve annotate comment
May 29, 2024
IWANABETHATGUY
force-pushed
the
feat/preserve-annotate-comment1
branch
from
May 29, 2024 16:52
3aca9f5
to
4586bb4
Compare
Dunqing
reviewed
May 29, 2024
IWANABETHATGUY
force-pushed
the
feat/preserve-annotate-comment1
branch
from
May 30, 2024 02:04
4586bb4
to
0fe3ac9
Compare
chore: 🤖 lint chore: 🤖 typos
IWANABETHATGUY
force-pushed
the
feat/preserve-annotate-comment1
branch
from
May 30, 2024 03:17
0fe3ac9
to
f556a60
Compare
This was referenced Jun 6, 2024
Closed
Closed
Closed
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Jun 7, 2024
## [0.4.3] - 2024-06-07 ### Features - 1fb9d23 linter: Add fixer for no-useless-fallback-in-spread rule (#3544) (Don Isaac) - 6506d08 linter: Add fixer for no-single-promise-in-promise-methods (#3531) (Don Isaac) - daf559f linter: Eslint-plugin-jest/no-large-snapshot (#3436) (cinchen) - 4c17bc6 linter: Eslint/no-constructor-return (#3321) (谭光志) - 4a075cc linter/jsdoc: Implement require-param rule (#3554) (Yuji Sugiura) - 747500a linter/jsdoc: Implement require-returns-type rule (#3458) (Yuji Sugiura) - 6b39654 linter/tree-shaking: Support options (#3504) (Wang Wenzhe) - 0cdb45a oxc_codegen: Preserve annotate comment (#3465) (IWANABETHATGUY) ### Bug Fixes - b188778 linter/eslint: Fix `require-await` false positives in `ForOfStatement`. (#3457) (rzvxa) - 350cd91 parser: Should parser error when function declaration has no name (#3461) (Dunqing) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-codegen
Area - Code Generation
A-linter
Area - Linter
A-minifier
Area - Minifier
A-transformer
Area - Transformer / Transpiler
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/* #__NO_SIDE_EFFECTS__ */
and/* #__PURE__ */