fix(traverse): change visit order for Function

[overlookmotel]

Alter Traverse's visitation order for fields of Function, to match the change made to Visit in #3681.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• fix(traverse): change visit order for Function #3685 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[overlookmotel]

@Dunqing You mentioned this in #3681 (comment).

FYI, all that's required to alter Traverse's visitation order is to alter the order of the fields in the type definition, and then run oxc_traverse's codegen.

Do we also need to change the visitation order in VisitMut to match?

[codspeed-hq]

CodSpeed Performance Report

Merging #3685 will not alter performance

_{Comparing 06-15-fix_traverse_change_visit_order_for_function_ (1533e9f) with main (568b647)}

Summary

✅ 22 untouched benchmarks

[Dunqing]

@Dunqing You mentioned this in #3681 (comment).

FYI, all that's required to alter Traverse's visitation order is to alter the order of the fields in the type definition, and then run oxc_traverse's codegen.

Got it.

Do we also need to change the visitation order in VisitMut to match?

Yes, I forgot to change VisitMut

[overlookmotel]

I assume type_parameters should be visited before this_param, not after. this_param is ignored by Visit so can't copy the behavior from Visit. Is that right?

[Dunqing]

I assume type_parameters should be visited before this_param, not after. this_param is ignored by Visit so can't copy the behavior from Visit. Is that right?

You're right, the Visit lacks many AST visits, and we might need a script to generate Visit.