refactor(semantic/cfg): cleanup control flow and it's builder. #3650

rzvxa · 2024-06-12T23:51:08Z

Removed remaining parts of the old CFG implementation and some cleanups here and there.

graphite-app · 2024-06-12T23:51:14Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

rzvxa · 2024-06-12T23:51:31Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

codspeed-hq · 2024-06-12T23:56:13Z

CodSpeed Performance Report

Merging #3650 will not alter performance

_{Comparing 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder (4c15f56) with 05-11-feat_linter_eslint_add_no_unreachable_rule (9cc5fb5)}

Summary

✅ 22 untouched benchmarks

graphite-app · 2024-06-13T07:25:13Z

Merge activity

Jun 13, 3:25 AM EDT: Boshen added this pull request to the Graphite merge queue.
Jun 13, 3:45 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.
Jun 13, 3:45 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3547.
Jun 13, 4:07 AM EDT: Boshen added this pull request to the Graphite merge queue.
Jun 13, 4:07 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.
Jun 13, 4:08 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3566.
Jun 13, 4:36 AM EDT: Boshen added this pull request to the Graphite merge queue.
Jun 13, 4:39 AM EDT: CI is running for this PR on a draft PR: #3656
Jun 13, 4:40 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to The Graphite App does not appear to have permissions required for parallel CI.
Jun 13, 4:41 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3238.
Jun 13, 5:37 AM EDT: Boshen added this pull request to the Graphite merge queue.
Jun 13, 5:38 AM EDT: CI is running for this PR on a draft PR: #3657
Jun 13, 5:41 AM EDT: Boshen merged this pull request with the Graphite merge queue via draft PR: #3657.

Removed remaining parts of the old CFG implementation and some cleanups here and there.

rzvxa · 2024-06-13T09:37:33Z

@Boshen This stack seems to fail in resolution in each step, Should I brute force the merge by manually resolving them?

Removed remaining parts of the old CFG implementation and some cleanups here and there.

## [0.4.4] - 2024-06-14 ### Features - 8f5655d linter: Add eslint/no-useless-constructor (#3594) (Don Isaac) - 29c78db linter: Implement @typescript-eslint/explicit-function-return-type (#3455) (kaykdm) - 21d3425 linter: Typescript-eslint no-useless-empty-export (#3605) (keita hino) - 85c3b83 linter: Eslint-plugin-jest/max-nested-describes (#3585) (cinchen) - f6d9ca6 linter: Add `eslint/sort-imports` rule (#3568) (Wang Wenzhe) - 046ff3f linter/eslint: Add `no_unreachable` rule. (#3238) (rzvxa) - e32ce00 linter/jsdoc: Implement require-param-name rule (#3636) (Yuji Sugiura) - 110661c linter/jsdoc: Implement require-param-description (#3621) (Yuji Sugiura) - d6370f1 linter/jsdoc: Implement require-param-type rule (#3601) (Yuji Sugiura) - d9c5b33 semantic/cfg: Add `Condition` instruction. (#3567) (Ali Rezvani) - f2dfd66 semantic/cfg: Add iteration instructions. (#3566) (rzvxa) ### Bug Fixes - f0b689d linter: Panic in jsdoc/require-param (#3590) (Don Isaac) - e148a32 semantic/cfg: Correct unreachability propagation in try-finally. (#3667) (Ali Rezvani) ### Refactor - 84304b4 linter: Add a `ctx.module_record()` method (#3637) (Boshen) - f98f777 linter: Add rule fixer (#3589) (Don Isaac) - fa11644 linter: Pass `Rc` by value (#3587) (overlookmotel) - f702fb9 semantic/cfg: Cleanup control flow and it's builder. (#3650) (rzvxa) - 5793ff1 transformer: Replace `&’a Trivias` with `Rc<Trivias>` (#3580) (Dunqing) Co-authored-by: Boshen <Boshen@users.noreply.github.com>

## [0.15.0] - 2024-06-18 - 0537d29 cfg: [**BREAKING**] Move control flow to its own crate. (#3728) (rzvxa) - 5c38a0f codegen: [**BREAKING**] New code gen API (#3740) (Boshen) - 4bce59d semantic/cfg: [**BREAKING**] Re-export `petgraph` as `control_flow::graph`. (#3722) (rzvxa) - 534242a codegen: [**BREAKING**] Remove `CodegenOptions::enable_typescript` (#3674) (Boshen) - 0578ece ast: [**BREAKING**] Remove `ExportDefaultDeclarationKind::TSEnumDeclaration` (#3666) (Dunqing) ### Features - 5a99d30 codegen: Improve codegen formatting (#3735) (Boshen) - bf9b38a codegen: Improve codegen formatting (#3731) (Boshen) - 4a004e2 codegen: Print TSImport remaining fields (#3695) (Dunqing) - a56cb1b codegen: Print accessibility for MethodDefinition (#3690) (Dunqing) - 38a75e5 coverage: Improve codegen (#3729) (Boshen) - 750a534 coverage: Transformer idempotency test (#3691) (Boshen) - ee627c3 isolated-declarations: Create unique name for `_default` (#3730) (Dunqing) - 81e9526 isolated-declarations: Inferring set accessor parameter type from get accessor return type (#3725) (Dunqing) - 77d5533 isolated-declarations: Report errors that are consistent with typescript. (#3720) (Dunqing) - 8f5655d linter: Add eslint/no-useless-constructor (#3594) (Don Isaac) - 046ff3f linter/eslint: Add `no_unreachable` rule. (#3238) (rzvxa) - 0b8098a napi: Isolated-declaration (#3718) (Boshen) - 527bfc8 npm/oxc-transform: Setup npm/oxc-transform and publish (Boshen) - d65c652 parser: Display jsx mismatch error, e.g. `<Foo></Bar>` (#3696) (Boshen) - 9c31ed9 semantic/cfg: Propagate unreachable edges through subgraphs. (#3648) (rzvxa) - d9c5b33 semantic/cfg: Add `Condition` instruction. (#3567) (Ali Rezvani) - f2dfd66 semantic/cfg: Add iteration instructions. (#3566) (rzvxa) - 910193e transformer-dts: Report error for super class (#3711) (Dunqing) - 413d7be transformer-dts: Transform enum support (#3710) (Dunqing) - 35c382e transformer-dts: Remove type annotation from private field (#3689) (Dunqing) - 0e6d3ce transformer-dts: Report error for async function and generator (#3688) (Dunqing) - b22b59a transformer-dts: Transform namespace support (#3683) (Dunqing) - 4f2db46 transformer-dts: `--isolatedDeclarations` dts transform (#3664) (Dunqing) ### Bug Fixes - 2158268 ast: Incorrect visit order in function (#3681) (Dunqing) - da1e2d0 codegen: Improve typescript codegen (#3708) (Boshen) - f1b793f isolated-declarations: Function overloads reaching unreachable (#3739) (Dunqing) - 0fbecdc isolated-declarations: Should be added to references, not bindings (#3726) (Dunqing) - 8f64d99 minifier: Respect `join_vars: false` option (#3724) (mysteryven) - 70fc69b semantic: Add Eq to CtxFlags (#3651) (Yuji Sugiura) - 7a58fec semantic/cfg: Issue in unlabeled `Ctx`s. (#3678) (rzvxa) - abd6ac8 semantic/cfg: Discrete finalization path after `NewFunction`s. (#3671) (rzvxa) - e148a32 semantic/cfg: Correct unreachability propagation in try-finally. (#3667) (Ali Rezvani) - 59666e0 transformer: Do not rename accessible identifier references (#3623) (Dunqing) - 90743e2 traverse: Change visit order for `Function` (#3685) (overlookmotel) ### Performance - 2717a1a semantic/cfg: Lower the visits in `neighbors_filtered_by_edge_weight`. (#3676) (rzvxa) ### Refactor - fa7a6ba codegen: Add `gen` method to ast nodes (#3687) (Boshen) - 09b92b6 codegen: Move `gen_ts` into `gen` to make searching things easier (#3680) (Boshen) - 3c59735 isolated-declarations: Remove `TransformDtsCtx` (#3719) (Boshen) - 815260e isolated-declarations: Decouple codegen (#3715) (Boshen) - 7ec44f8 semantic: Rename `cfg` macro to `control_flow`. (#3742) (rzvxa) - d8ad321 semantic: Make control flow generation optional. (#3737) (rzvxa) - a94a72d semantic: Expose 1 checker function instead of 2 (#3694) (Boshen) - bd8d115 semantic/cfg: Remove unused types. (#3677) (rzvxa) - f702fb9 semantic/cfg: Cleanup control flow and it's builder. (#3650) (rzvxa) - 4f16664 transformer_dts: Create a `Program` for codegen (#3679) (Boshen) Co-authored-by: Boshen <Boshen@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Jun 12, 2024

rzvxa mentioned this pull request Jun 12, 2024

feat(semantic/cfg): propagate unreachable edges through subgraphs. #3648

Closed

rzvxa marked this pull request as ready for review June 13, 2024 00:10

rzvxa force-pushed the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch 2 times, most recently from 7460823 to 14f4cca Compare June 13, 2024 01:17

rzvxa force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch from 5faf0e9 to 0cf1b04 Compare June 13, 2024 04:18

rzvxa force-pushed the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch from 14f4cca to 0a806d7 Compare June 13, 2024 04:19

rzvxa force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch from 0cf1b04 to 2efdc8b Compare June 13, 2024 04:24

rzvxa force-pushed the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch from 0a806d7 to 5c87d1f Compare June 13, 2024 04:24

Boshen force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch from 2efdc8b to 707d42e Compare June 13, 2024 07:32

Boshen pushed a commit that referenced this pull request Jun 13, 2024

refactor(semantic/cfg): cleanup control flow and it's builder. (#3650)

24715ad

Removed remaining parts of the old CFG implementation and some cleanups here and there.

Boshen force-pushed the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch from 5c87d1f to 24715ad Compare June 13, 2024 07:33

Boshen force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch from 707d42e to c97a3b4 Compare June 13, 2024 07:39

Boshen pushed a commit that referenced this pull request Jun 13, 2024

refactor(semantic/cfg): cleanup control flow and it's builder. (#3650)

839b0dd

Removed remaining parts of the old CFG implementation and some cleanups here and there.

Boshen force-pushed the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch from 24715ad to 839b0dd Compare June 13, 2024 07:40

rzvxa force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch from c97a3b4 to 433e053 Compare June 13, 2024 08:30

rzvxa added a commit that referenced this pull request Jun 13, 2024

refactor(semantic/cfg): cleanup control flow and it's builder. (#3650)

918468b

Removed remaining parts of the old CFG implementation and some cleanups here and there.

rzvxa force-pushed the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch from 839b0dd to 918468b Compare June 13, 2024 08:30

Boshen pushed a commit that referenced this pull request Jun 13, 2024

refactor(semantic/cfg): cleanup control flow and it's builder. (#3650)

8e95259

Removed remaining parts of the old CFG implementation and some cleanups here and there.

refactor(semantic/cfg): cleanup control flow and it's builder. (#3650)

4c15f56

Removed remaining parts of the old CFG implementation and some cleanups here and there.

rzvxa force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch from 433e053 to 9cc5fb5 Compare June 13, 2024 09:03

rzvxa force-pushed the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch from 918468b to 4c15f56 Compare June 13, 2024 09:03

Boshen pushed a commit that referenced this pull request Jun 13, 2024

refactor(semantic/cfg): cleanup control flow and it's builder. (#3650)

f702fb9

Removed remaining parts of the old CFG implementation and some cleanups here and there.

graphite-app bot deleted the branch 05-11-feat_linter_eslint_add_no_unreachable_rule June 13, 2024 09:41

graphite-app bot closed this Jun 13, 2024

graphite-app bot deleted the 06-13-refactor_semantic_cfg_cleanup_control_flow_and_it_s_builder branch June 13, 2024 09:41

github-actions bot mentioned this pull request Jun 14, 2024

Release oxlint v0.4.4 #3669

Merged

github-actions bot mentioned this pull request Jun 18, 2024

Release crates v0.15.0 #3743

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(semantic/cfg): cleanup control flow and it's builder. #3650

refactor(semantic/cfg): cleanup control flow and it's builder. #3650

rzvxa commented Jun 12, 2024 •

edited

Loading

graphite-app bot commented Jun 12, 2024

rzvxa commented Jun 12, 2024 •

edited

Loading

codspeed-hq bot commented Jun 12, 2024 •

edited

Loading

graphite-app bot commented Jun 13, 2024 •

edited

Loading

rzvxa commented Jun 13, 2024 •

edited

Loading

refactor(semantic/cfg): cleanup control flow and it's builder. #3650

refactor(semantic/cfg): cleanup control flow and it's builder. #3650

Conversation

rzvxa commented Jun 12, 2024 • edited Loading

graphite-app bot commented Jun 12, 2024

Your org has enabled the Graphite merge queue for merging into main

rzvxa commented Jun 12, 2024 • edited Loading

codspeed-hq bot commented Jun 12, 2024 • edited Loading

CodSpeed Performance Report

Merging #3650 will not alter performance

Summary

graphite-app bot commented Jun 13, 2024 • edited Loading

Merge activity

rzvxa commented Jun 13, 2024 • edited Loading

rzvxa commented Jun 12, 2024 •

edited

Loading

rzvxa commented Jun 12, 2024 •

edited

Loading

codspeed-hq bot commented Jun 12, 2024 •

edited

Loading

graphite-app bot commented Jun 13, 2024 •

edited

Loading

rzvxa commented Jun 13, 2024 •

edited

Loading