fix(codegen): print parenthesis properly

[Boshen]

TSParenthesizedType handles parenthesis in ts types.

It should be considered a bug if parenthesis is not printed correctly after this PR.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Boshen]

• fix(codegen): print parenthesis properly #4245 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite

[graphite-app]

Merge activity

• Jul 13, 11:37 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 14, 12:09 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Jul 14, 12:17 AM EDT: Boshen merged this pull request with the Graphite merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #4245 will degrade performances by 4.16%

_{Comparing 07-13-feat_codegen_wrap_parenthesis_for_ts_types (e167ef7) with main (3e099fe)}

Summary

❌ 2 regressions
✅ 30 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	07-13-feat_codegen_wrap_parenthesis_for_ts_types	Change
❌	minifier[antd.js]	350.6 ms	365.8 ms	-4.16%
❌	minifier[typescript.js]	648.1 ms	675.7 ms	-4.09%

[armano2]

TSParenthesizedType handles parenthesis in ts types.

in ts-eslint: this node was created just for compatibility with eslint when we where converting it 1-1 from ts, and we where not able to reuse es one, or skip it as eslint core rules often break because they are doing some "funky" stuff with selectors, and they are not explicit enough to handle 'extended types'.

you may want to skip it, in simillar way to what babel does as you are handling both parsing and linting

ref: babel/babel#9546
ref: typescript-eslint/typescript-eslint#3136

ideally type parenthesis would be handled while printing in accordance to precedence, similar to how regular parenthesis are handled

---

i'm not that familiar yet with code base, but it looks like thats what you did, is that correct?

[Boshen]

I'm on the same boat right now, introducing TSParenthesizedType to get everything printed correctly on the main branch.

before removing the TSParenthesizedType node, I need to

• add more test coverage for ts codegen
• understand how to print parenthesis on ts types properly
• port the reference implementation from typescript compile