refactor(semantic): update the order of `visit_function` and `Visit` fields in the builder to be consistent #4248

Dunqing · 2024-07-14T06:26:14Z

Same as #4195

graphite-app · 2024-07-14T06:26:19Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Dunqing · 2024-07-14T06:26:28Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

codspeed-hq · 2024-07-14T06:31:48Z

CodSpeed Performance Report

Merging #4248 will not alter performance

_{Comparing 07-14-refactor_semantic_update_the_order_of_visit_function_and_visit_fields_in_the_builder_to_be_consistent (ace4f1f) with main (d1c4be0)}

Summary

✅ 32 untouched benchmarks

crates/oxc_semantic/src/builder.rs

graphite-app · 2024-07-14T11:38:27Z

Merge activity

Jul 14, 7:38 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 14, 7:38 AM EDT: Boshen added this pull request to the Graphite merge queue.
Jul 14, 7:45 AM EDT: Boshen merged this pull request with the Graphite merge queue.

…fields in the builder to be consistent (#4248) Same as #4195

## [0.6.1] - 2024-07-17 ### Features - 83c2c62 codegen: Add option for choosing quotes; remove slow `choose_quot` method (#4219) (Boshen) - 1f8968a linter: Add eslint-plugin-promise rules: avoid-new, no-new-statics, params-names (#4293) (Jelle van der Waa) - a4dc56c linter: Add fixer for unicorn/no_useless_promise_resolve_reject (#4244) (Burlin) - 6fb808f linter: Add typescript-eslint/no-confusing-non-null-assertion (#4224) (Jaden Rodriguez) - 126b66c linter: Support eslint-plugin-vitest/valid-describe-callback (#4185) (cinchen) - 05b9a73 linter: Support eslint-plugin-vitest/valid-expect (#4183) (cinchen) - 3e56b2b linter: Support eslint-plugin-vitest/no-test-prefixes (#4182) (cinchen) - 3016f03 linter: Let fixer functions return a `None` fix (#4210) (DonIsaac) - bbe6137 linter: Implement unicorn/no-useless-undefined (#4079) (Burlin) - 20cdb1f semantic: Align class scope with typescript (#4195) (Dunqing) ### Bug Fixes - 9df60da linter: Correct find first non whitespace logic in @typescript-eslint/consistent-type-imports (#4198) (mysteryven) - 67240dc linter: Not ignore adjacent spans when fixing (#4217) (mysteryven) - dd07a54 linter: Global variables should always check the builtin variables (#4209) (Jelle van der Waa) - 351ecf2 semantic: Incorrect resolve references for `TSTypeQuery` (#4310) (Dunqing) - 1108f2a semantic: Resolve references to the incorrect symbol (#4280) (Dunqing) ### Performance - 0fdc88b linter: Optimize no-dupe-keys (#4292) (lucab) ### Refactor - 2c7bb9f ast: Pass final `ScopeFlags` into `visit_function` (#4283) (overlookmotel) - aa22073 codegen: Improve print API (#4196) (Boshen) - b5a8f3c linter: Use get_first_parameter_name from unicorn utils (#4255) (Jelle van der Waa) - 7089a3d linter: Split up fixer code into separate files (#4222) (DonIsaac) - ace4f1f semantic: Update the order of `visit_function` and `Visit` fields in the builder to be consistent (#4248) (Dunqing) - 7f1addd semantic: Correct scope in CatchClause (#4192) (Dunqing) Co-authored-by: Boshen <Boshen@users.noreply.github.com>

## [0.21.0] - 2024-07-18 - d7ab0b8 semantic: [**BREAKING**] Simplify node creation (#4226) (lucab) ### Features - af4dc01 ast: Align ts ast scope with typescript (#4253) (Dunqing) - 83c2c62 codegen: Add option for choosing quotes; remove slow `choose_quot` method (#4219) (Boshen) - 5d17675 mangler: Add debug mode (#4314) (Boshen) - e3e663b mangler: Initialize crate and integrate into minifier (#4197) (Boshen) - c818472 minifier: Dce conditional expression `&&` or `||` (#4190) (Boshen) - 8a190eb oxc: Export `oxc_mangler` (Boshen) - 20cdb1f semantic: Align class scope with typescript (#4195) (Dunqing) - 92ee774 semantic: Add `ScopeFlags::CatchClause` for use in CatchClause (#4205) (Dunqing) - 205c259 sourcemap: Support SourceMapBuilder#token_chunks (#4220) (underfin) - 7eb960d transformer: Decode xml character entity `&#xhhhh` and `&#nnnn;` (#4235) (Boshen) ### Bug Fixes - bf3d8d3 codegen: Print annotation comment inside parens for new and call expressions (#4290) (Boshen) - 084ab76 codegen: Use `ryu-js` for f64 to string (Boshen) - e167ef7 codegen: Print parenthesis properly (#4245) (Boshen) - c65198f codegen: Choose the right quote for jsx attribute string (#4236) (Boshen) - be82c28 codegen: Print `JSXAttributeValue::StringLiteral` directly (#4231) (Boshen) - 3df9e69 mangler: No shorthand `BindingProperty`; handle var hoisting and export variables (#4319) (Boshen) - f144082 minifier: RemoveDeadCode should visit nested expression (#4268) (underfin) - 66b455a oxc_codegen: Avoid print same pure comments multiple time (#4230) (IWANABETHATGUY) - 9a87e41 parser: Avoid crashing on invalid const modifier (#4267) (lucab) - 641a78b parser: Fix tests for number parsing (#4254) (overlookmotel) - 9badac0 semantic: Avoid var hosting insert the var variable to the `CatchClause` scope (#4337) (Dunqing) - 95e15b6 semantic: Incorrect resolve references for `ExportSpecifier` (#4320) (Dunqing) - c362bf7 semantic: Incorrect resolve references for `TSInterfaceHeritage` (#4311) (Dunqing) - 351ecf2 semantic: Incorrect resolve references for `TSTypeQuery` (#4310) (Dunqing) - 1108f2a semantic: Resolve references to the incorrect symbol (#4280) (Dunqing) - 22d56bd semantic: Do not resolve references after `FormalParameters` in TS type (#4241) (overlookmotel)- 1c117eb Avoid print extra semicolon after accessor property (#4199) (IWANABETHATGUY) ### Performance - a8dc4f3 parser: Speed up parsing numbers with `_` separators (#4259) (overlookmotel) - b94540d parser: Speed up parsing octal literals (#4258) (overlookmotel) - a7b328c parser: Faster parsing decimal numbers (#4257) (overlookmotel) - f9d3f2e semantic: Inline ast record functions (#4272) (overlookmotel) - 8fad7db semantic: Reduce `AstNodeId` to `u32` (#4264) (overlookmotel) - 23743db semantic: Do not record ast nodes for cfg if cfg disabled (#4263) (overlookmotel) - da69076 semantic: Reduce overhead of cfg recording ast nodes (#4262) (overlookmotel) - cb15303 semantic: Reduce memory copies (#4216) (overlookmotel) - ef4c1f4 semantic: Reduce lookups (#4214) (overlookmotel) - f23e54f semantic: Recycle unresolved references hash maps (#4213) (overlookmotel) - 2602ce2 semantic: Reuse existing map of unresolved refs (#4206) (lucab) ### Refactor - 2c7bb9f ast: Pass final `ScopeFlags` into `visit_function` (#4283) (overlookmotel) - 3e099fe ast: Move `enter_scope` after `visit_binding_identifier` (#4246) (Dunqing) - aab7aaa ast/visit: Fire node events as the outermost one. (#4203) (rzvxa) - d1c4be0 codegen: Clean up annotation_comment (Boshen) - 06197b8 codegen: Separate tests (Boshen) - aa22073 codegen: Improve print API (#4196) (Boshen) - c5731a5 semantic: Remove defunct code setting ScopeFlags twice (#4286) (overlookmotel) - 16698bc semantic: Move function/class-specific code into specific visitors (#4278) (overlookmotel) - ee16668 semantic: Rename function param (#4277) (overlookmotel) - 25f0771 semantic: Alter syntax of `control_flow!` macro (#4275) (overlookmotel) - 639fd48 semantic: Comment why extra CFG enabled check (#4274) (overlookmotel) - c418bf5 semantic: Directly record `current_node_id` when adding a scope (#4265) (Dunqing) - ace4f1f semantic: Update the order of `visit_function` and `Visit` fields in the builder to be consistent (#4248) (Dunqing) - 8bfeabf semantic: Simplify adding `SymbolFlags::Export` (#4249) (Dunqing) - dc2b3c4 semantic: Add strict mode in scope flags for class definitions (#4156) (Dunqing) - 81ed588 semantic: Convert scope fields to IndexVecs (#4208) (lucab) - bbe5ded semantic: Set `current_scope_id` to `scope_id` in `enter_scope` (#4193) (Dunqing) - 7f1addd semantic: Correct scope in CatchClause (#4192) (Dunqing) - fc0b17d syntax: Turn the `AstNodeId::dummy` into a constant field. (#4308) (rzvxa) - a197e01 transformer/typescript: Remove unnecessary code (#4321) (Dunqing) - 1458d81 visit: Add `#[inline]` to empty functions (#4330) (overlookmotel) Co-authored-by: Boshen <Boshen@users.noreply.github.com>

Found in #4328 Same as #4248

Dunqing changed the title ~~refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent~~ refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent Jul 14, 2024

github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST A-isolated-declarations Isolated Declarations labels Jul 14, 2024

Dunqing changed the title ~~refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent~~ refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent Jul 14, 2024

overlookmotel reviewed Jul 14, 2024

View reviewed changes

crates/oxc_semantic/src/builder.rs Show resolved Hide resolved

Dunqing force-pushed the 07-14-refactor_semantic_update_the_order_of_visit_function_and_visit_fields_in_the_builder_to_be_consistent branch from 798ad93 to 810bf2e Compare July 14, 2024 10:36

Dunqing changed the base branch from main to 07-14-refactor_semantic_simplify_adding_symbolflags_export July 14, 2024 10:36

Dunqing mentioned this pull request Jul 14, 2024

refactor(semantic): simplify adding SymbolFlags::Export #4249

Merged

overlookmotel mentioned this pull request Jul 14, 2024

Record AstNodeId for all scopes in Semantic #4444

Closed

Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 14, 2024

refactor(semantic): update the order of visit_function and Visit …

ace4f1f

…fields in the builder to be consistent (#4248) Same as #4195

Boshen force-pushed the 07-14-refactor_semantic_simplify_adding_symbolflags_export branch from 9d365d8 to 8bfeabf Compare July 14, 2024 11:39

Boshen force-pushed the 07-14-refactor_semantic_update_the_order_of_visit_function_and_visit_fields_in_the_builder_to_be_consistent branch from 810bf2e to ace4f1f Compare July 14, 2024 11:39

Boshen changed the base branch from 07-14-refactor_semantic_simplify_adding_symbolflags_export to main July 14, 2024 11:43

graphite-app bot merged commit ace4f1f into main Jul 14, 2024
27 checks passed

graphite-app bot deleted the 07-14-refactor_semantic_update_the_order_of_visit_function_and_visit_fields_in_the_builder_to_be_consistent branch July 14, 2024 11:45

This was referenced Jul 17, 2024

Release crates v0.21.0 #4325

Closed

Release oxlint v0.6.1 #4326

Merged

github-actions bot mentioned this pull request Jul 18, 2024

Release crates v0.21.0 #4338

Merged

github-actions bot mentioned this pull request Jul 18, 2024

Release crates v0.21.0 #4344

Merged

Dunqing mentioned this pull request Jul 19, 2024

refactor(ast)!: reorder fields of ArrowFunctionExpression #4364

Merged

Boshen pushed a commit that referenced this pull request Jul 19, 2024

refactor(ast)!: reorder fields of ArrowFunctionExpression (#4364)

f68b659

Found in #4328 Same as #4248

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(semantic): update the order of `visit_function` and `Visit` fields in the builder to be consistent #4248

refactor(semantic): update the order of `visit_function` and `Visit` fields in the builder to be consistent #4248

Dunqing commented Jul 14, 2024 •

edited

Loading

graphite-app bot commented Jul 14, 2024

Dunqing commented Jul 14, 2024 •

edited

Loading

codspeed-hq bot commented Jul 14, 2024 •

edited

Loading

graphite-app bot commented Jul 14, 2024 •

edited

Loading

refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent #4248

refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent #4248

Conversation

Dunqing commented Jul 14, 2024 • edited Loading

graphite-app bot commented Jul 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Dunqing commented Jul 14, 2024 • edited Loading

codspeed-hq bot commented Jul 14, 2024 • edited Loading

CodSpeed Performance Report

Merging #4248 will not alter performance

Summary

graphite-app bot commented Jul 14, 2024 • edited Loading

Merge activity

refactor(semantic): update the order of `visit_function` and `Visit` fields in the builder to be consistent #4248

refactor(semantic): update the order of `visit_function` and `Visit` fields in the builder to be consistent #4248

Dunqing commented Jul 14, 2024 •

edited

Loading

Dunqing commented Jul 14, 2024 •

edited

Loading

codspeed-hq bot commented Jul 14, 2024 •

edited

Loading

graphite-app bot commented Jul 14, 2024 •

edited

Loading