Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint/sort-keys #4845

Merged
merged 37 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
9841b35
chore: added scaffolding for eslint/sort-keys
Goldziher Aug 11, 2024
3a8fad3
feat: sorts-keys initial implementation
Goldziher Aug 11, 2024
898ccdd
feat: add sorting logic
Goldziher Aug 12, 2024
ef83c4f
feat: almost passing tests
Goldziher Aug 12, 2024
5843013
Merge branch 'oxc-project:main' into main
Goldziher Aug 12, 2024
5e800bd
Merge branch 'main' into main
Goldziher Aug 12, 2024
c5bdecb
chore: addressed review comments
Goldziher Aug 12, 2024
0d777a1
Merge branch 'main' of github.com:Goldziher/oxc
Goldziher Aug 12, 2024
f60501f
chore: update doc string
Goldziher Aug 12, 2024
cda74f5
Update Cargo.toml
Goldziher Aug 13, 2024
2bf85a7
chore: revert unintentional change to cargo.toml
Goldziher Aug 13, 2024
4668554
Merge branch 'main' into main
Goldziher Aug 13, 2024
b99ab32
Merge branch 'main' into main
DonIsaac Aug 13, 2024
298c240
Merge branch 'oxc-project:main' into main
Goldziher Aug 14, 2024
34e9aef
chore: fix failing snapshot
Goldziher Aug 14, 2024
ab43240
Merge branch 'main' into main
DonIsaac Aug 14, 2024
091f773
chore: run just r
Goldziher Aug 14, 2024
8cd8e75
Merge branch 'main' into main
Goldziher Aug 14, 2024
ca29640
Merge branch 'main' of github.com:Goldziher/oxc
Goldziher Aug 14, 2024
9b3cbca
Merge branch 'main' into main
Goldziher Aug 18, 2024
8315aa0
chore: fixed clippy issues
Goldziher Aug 18, 2024
232b5f0
chore: added semi-columns to examples
Goldziher Aug 18, 2024
3cd0ec8
Merge branch 'main' into main
DonIsaac Aug 19, 2024
a28963b
chore: fix missing equal signs
Goldziher Aug 19, 2024
aaa6772
Merge branch 'main' of github.com:Goldziher/oxc
Goldziher Aug 19, 2024
e61002d
Merge branch 'main' into main
Goldziher Aug 19, 2024
d31c9bd
Merge branch 'main' into main
Goldziher Aug 22, 2024
6c8b4c8
chore: removed todo comments
Goldziher Aug 22, 2024
b35a82e
Merge branch 'main' of github.com:Goldziher/oxc
Goldziher Aug 22, 2024
8b21362
Merge branch 'main' into main
DonIsaac Aug 31, 2024
1e027f1
Merge branch 'main' into main
DonIsaac Sep 6, 2024
719b608
chore: address review comments
Goldziher Sep 6, 2024
c82506c
Merge branch 'main' of github.com:oxc-project/oxc
Goldziher Sep 7, 2024
7f9fa78
chore: synced with upstream
Goldziher Sep 11, 2024
a3a7128
chore: ignore clippy issue
Goldziher Sep 11, 2024
f9547ff
chore: applied just r
Goldziher Sep 11, 2024
45418d6
Merge branch 'main' into main
DonIsaac Sep 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ ignored = ["napi", "oxc_transform_napi", "prettyplease"]
[profile.dev]
# Disabling debug info speeds up local and CI builds,
# and we don't rely on it for debugging that much.
debug = false
# debug = false
Goldziher marked this conversation as resolved.
Show resolved Hide resolved

[profile.dev.package]
# Compile macros with some optimizations to make consuming crates build faster
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ mod eslint {
pub mod unicode_bom;
pub mod use_isnan;
pub mod valid_typeof;
pub mod sort_keys;
}

mod typescript {
Expand Down Expand Up @@ -549,6 +550,7 @@ oxc_macros::declare_all_lint_rules! {
eslint::require_yield,
eslint::symbol_description,
eslint::sort_imports,
eslint::sort_keys,
eslint::unicode_bom,
eslint::use_isnan,
eslint::valid_typeof,
Expand Down
Loading